Incomplete metadata is return for an instance when booting from volume instead of image

[Matthew Macdonald-Wallace]

When booting from a cinder volume, metadata that would normally be included as part of a "standard" glance install/boot is not included in the volume metadata.

When booting from a volume, the volume metadata should be returned by Cinder in the same way that the image metadata is returned by Glance when booting from an image.

[Matthew Macdonald-Wallace (proffalken)]

nova/compute/api.py:

 528 if image_href:
 529 (image_service, image_id) = glance.get_remote_image_service(
 530 context, image_href)
 531 image = image_service.show(context, image_id)
 532 if image['status'] != 'active':
 533 raise exception.ImageNotActive(image_id=image_id)
 534 else:
 535 image = {}

This probably should talk to glance if we don't have an image_href to get the metadata from there?

[Matthew Macdonald-Wallace (proffalken)]

https://review.openstack.org/#/c/27898 appears to cover much of this, will work on integrating and testing that code now.

[Matthew Macdonald-Wallace (proffalken)]

I was looking in the wrong place above, fix enroute now.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/28969

[Loganathan Parthipan (parthipan)]

It'll be nice to get this long overdue fix merged. :)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/28969
Committed: http://github.com/openstack/nova/commit/e67641da51610a419ec8cf6562583d14a2b0fbd7
Submitter: Jenkins
Branch: master

commit e67641da51610a419ec8cf6562583d14a2b0fbd7
Author: Matthew Macdonald-Wallace <email address hidden>
Date: Fri Jun 7 15:20:00 2013 +0100

    Export volume metadata to new instances.

    Instances that are booted from volume currently miss out on glance
    metadata that instances booted from images receive. By extracting
    that data and passing it on in the create request we make it
    available to both sorts of instance boot, fixing bug 1175571.

    Change-Id: I8c01ba3065a909ca8e1805db9a10a423b10fe289

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/33296

[Matthew Macdonald-Wallace (HPCS) (matthew-macdonald-wallace)]

The original patch retrieved the correct metadata from Cinder, however it did not apply it to the Nova instance.

This latest patch set ensures that any metadata added to a Glance image is transferred to the instance even if it is booted from a volume.