Avoid all() query when generating tunnel id

Bug #1174998 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Salvatore Orlando

Bug Description

There is no need for: https://github.com/openstack/quantum/blob/master/quantum/plugins/openvswitch/ovs_db_v2.py#L371
Sql Alchemy could be used to extract directly the max value from tunnel.id, thus saving time especially when several hosts are employed.

This was observed by Jason in a recent review.
It's a negligible improvement, but a very easy one.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27875

Changed in quantum:
assignee: nobody → Salvatore Orlando (salvatore-orlando)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/27875
Committed: http://github.com/openstack/quantum/commit/bde296d1040a6c1397faebf80f0ba164bed2c937
Submitter: Jenkins
Branch: master

commit bde296d1040a6c1397faebf80f0ba164bed2c937
Author: Salvatore Orlando <email address hidden>
Date: Wed May 1 02:57:55 2013 +0200

    Use sql alchemy to fetch a scalar for the max tunnel id

    Bug 1174998

    Change-Id: I77203c81c2c910a1a601416efc4567f1320a2eef

Changed in quantum:
status: In Progress → Fix Committed
Changed in quantum:
milestone: none → havana-1
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.