Add rollback for Cisco plugin update_port failure

Bug #1174433 reported by Dane LeBlanc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Dane LeBlanc

Bug Description

In the Cisco plugin's update_port method, the port is first updated using the OVS plugin, and then the port is updated in the Nexus sub-plugin. If the update in the Nexus sub-plugin fails, the port update for the OVS plugin should be rolled back.

Also, the Cisco plugin's update_network method includes a call to the Nexus sub-plugin's update_network method, and this method is a no-op. The call to the sub-plugin's update_network (and the associated argument setup) should be removed for simplicity.

Tags: cisco
Dane LeBlanc (leblancd)
Changed in quantum:
assignee: nobody → Dane LeBlanc (leblancd)
tags: added: cisco
Dane LeBlanc (leblancd)
summary: - Rollbacks required in Cisco plugin update_network and update_port
+ Add rollback for Cisco plugin update_port
description: updated
summary: - Add rollback for Cisco plugin update_port
+ Add rollback for Cisco plugin update_port failure
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/29576

Changed in quantum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/29576
Committed: http://github.com/openstack/quantum/commit/87b2548e8845fa9710a1b89a642d06fd28148572
Submitter: Jenkins
Branch: master

commit 87b2548e8845fa9710a1b89a642d06fd28148572
Author: Dane LeBlanc <email address hidden>
Date: Fri May 17 11:42:59 2013 -0400

    Add rollback for Cisco plugin update_port failure

    Fixes bug 1174433

    This fix adds a rollback of the OVS plugin update_port operation
    following a failure to update the port in the Cisco Nexus sub-plugin.

    Also, this fix removes an unneccessary call to the Nexus sub-plugin's
    update_network method within the Cisco plugin model layer's
    update_network method (as well as the associated argument setup).
    The Nexus sub-plugin's update_network is a no-op, so there's no
    need to call it.

    Change-Id: I10cba0d7f1d632c7f77eb6c4a94ea82b958bc6a2

Changed in quantum:
status: In Progress → Fix Committed
Changed in quantum:
milestone: none → havana-2
Changed in quantum:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.