Invalid midi mapping xml silently ignored

[Musikpirat]

If the midi xml is not valid, importing it failes silently. There should be an error message telling this the user.

[Sean M. Pappalardo (pegasus-renegadetech)]

I think it depends on which part of the XML is invalid. Can you please attach an example invalid file we can test with?

[Sean M. Pappalardo (pegasus-renegadetech)]

Never mind, I found the problem.

RJ: this is a side effect of disabling qWarning() pop-ups. I depended on that in code that I wrote so that users would be notified of issues like this. Now what do we do?

[Sean M. Pappalardo (pegasus-renegadetech)]

Never mind, working on it by using a non-modal ErrorDialog.

[Sean M. Pappalardo (pegasus-renegadetech)]

Fixed in 1.11 r3846.

[RJ Skerry-Ryan (rryan)]

Cool, thanks for the fix.

On Mon, Apr 29, 2013 at 6:54 AM, Sean M. Pappalardo <
<email address hidden>> wrote:

> Fixed in 1.11 r3846.
>
> ** Changed in: mixxx/1.11
> Status: Confirmed => Fix Committed
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1173895
>
> Title:
> Invalid midi mapping xml silently ignored
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1173895/+subscriptions
>

[RJ Skerry-Ryan (rryan)]

(btw, you should commit with --fixes lp:XXXXXX in the future so the commit
is linked to the bug)

On Mon, Apr 29, 2013 at 9:43 AM, RJ Ryan <email address hidden> wrote:

> Cool, thanks for the fix.
>
>
> On Mon, Apr 29, 2013 at 6:54 AM, Sean M. Pappalardo <
> <email address hidden>> wrote:
>
>> Fixed in 1.11 r3846.
>>
>> ** Changed in: mixxx/1.11
>> Status: Confirmed => Fix Committed
>>
>> --
>> You received this bug notification because you are a member of Mixxx
>> Development Team, which is subscribed to Mixxx.
>> https://bugs.launchpad.net/bugs/1173895
>>
>> Title:
>> Invalid midi mapping xml silently ignored
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/mixxx/+bug/1173895/+subscriptions
>>
>
>

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7003