The engine_topic config option is broken

[Mark McLoughlin]

We have this:

    cfg.StrOpt('engine_topic',
               default='engine',
               help='the topic engine nodes listen on')]

and heat-api does use it:

    def __init__(self):
        super(EngineClient, self).__init__(
            topic=rpc.queue_get_for(None, CONF.engine_topic, CONF.host),
            default_version=self.BASE_RPC_API_VERSION)

but heat-engine *always* listens on the 'engine' topic:

    srv = engine.EngineService(cfg.CONF.host, 'engine')

There really is no good use case for a user to configure the topic name (in fact Russell and I were only recently saying that this shouldn't be configurable in nova) since it is scoped under the control_exchange namespace (barring the minor detail of bug #1173552 :-)

I reckon we should remove the config option now while we know for certain that nobody can be using it

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/27621

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27621
Committed: http://github.com/openstack/heat/commit/117e73ba572ea421deabb7bd05318388439e2056
Submitter: Jenkins
Branch: master

commit 117e73ba572ea421deabb7bd05318388439e2056
Author: Mark McLoughlin <email address hidden>
Date: Sat Apr 27 13:20:04 2013 +0100

    Remove engine_topic configuration option

    Fixes bug #1173575

    This is currently broken since heat-engine always listens to the
    'engine' topic and there isn't actually a good use case for this to be
    configurable, so let's kill it.

    Change-Id: I35c0292c921f81857f80a7f111df5ac330d54ecf