Incorrect logic in OVSQuantumAgent.port_unbound method

Bug #1173463 reported by Eugene Nikanorov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Eugene Nikanorov
Grizzly
Fix Released
Low
Gary Kotton

Bug Description

The following piece of code could throw KeyError while intention was to avoid that:
https://github.com/openstack/quantum/blob/master/quantum/plugins/openvswitch/agent/ovs_quantum_agent.py#L475

        if lvm.network_type == 'gre':
            if self.enable_tunneling:
                # remove inbound unicast flow
                self.tun_br.delete_flows(tun_id=lvm.segmentation_id,
                                         dl_dst=lvm.vif_ports[vif_id].vif_mac)

        if vif_id in lvm.vif_ports:
            del lvm.vif_ports[vif_id]

Tags: ovs
Changed in quantum:
assignee: nobody → Eugene Nikanorov (enikanorov)
Changed in quantum:
status: New → In Progress
tags: added: ovs
Gary Kotton (garyk)
tags: added: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27642

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/27642
Committed: http://github.com/openstack/quantum/commit/7dddca7ebd04d400436c3124220c0602a9a13482
Submitter: Jenkins
Branch: master

commit 7dddca7ebd04d400436c3124220c0602a9a13482
Author: Eugene Nikanorov <email address hidden>
Date: Sat Apr 27 20:43:13 2013 +0400

    Fix logic issue in OVSQuantumAgent.port_unbound method

    Fixes bug 1173463

    Change-Id: If2978fc4c38304667f6910085cb220491d236a11

Changed in quantum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/27645

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27815

Changed in quantum:
milestone: none → havana-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/27815
Committed: http://github.com/openstack/quantum/commit/b5c13293b3c587221d33df832ee8376bd971cbcd
Submitter: Jenkins
Branch: master

commit b5c13293b3c587221d33df832ee8376bd971cbcd
Author: Gary Kotton <email address hidden>
Date: Tue Apr 30 15:23:10 2013 +0000

    Treat unbound port

    Following a nice suggestion by S Orlando regarding the fix for
    bug 1173463

    Change-Id: I2fa2a2fa7852025f0c18ff27c5fffc5667ce8378

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/28352

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (stable/grizzly)

Reviewed: https://review.openstack.org/28352
Committed: http://github.com/openstack/quantum/commit/abf328868fb74e5f1eb51ba05ccf8e5bfca11c0c
Submitter: Jenkins
Branch: stable/grizzly

commit abf328868fb74e5f1eb51ba05ccf8e5bfca11c0c
Author: Gary Kotton <email address hidden>
Date: Tue Apr 30 15:23:10 2013 +0000

    Treat unbound port

    Following a nice suggestion by S Orlando regarding the fix for
    bug 1173463

    Change-Id: I2fa2a2fa7852025f0c18ff27c5fffc5667ce8378

tags: added: in-stable-grizzly
Gary Kotton (garyk)
tags: removed: grizzly-backport-potential
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: removed: in-stable-grizzly
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.