remove unecessary function argument in vmwareapi

Bug #1171376 reported by Yaguang Tang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Yaguang Tang
Grizzly
Fix Released
Medium
Unassigned

Bug Description

nova/virt/vmwareapi/vif.py

 37 def ensure_vlan_bridge(self, session, vif, cluster=None):
 38 """Create a vlan and bridge unless they already exist."""
 39 vlan_num = vif['network'].get_meta('vlan')
 40 bridge = vif['network']['bridge']
 41 vlan_interface = CONF.vmwareapi_vlan_interface
 42
 43 # Check if the vlan_interface physical network adapter exists on the
 44 # host.

the 'self' argument is unnecessary and when invoked, cause parameters error.

Tags: vmware
Yaguang Tang (heut2008)
Changed in nova:
assignee: nobody → Yaguang Tang (heut2008)
Yaguang Tang (heut2008)
tags: added: vmware
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27254

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/27254
Committed: http://github.com/openstack/nova/commit/588aa3625da1272a1225e01ddd0f70d02f7beac9
Submitter: Jenkins
Branch: master

commit 588aa3625da1272a1225e01ddd0f70d02f7beac9
Author: Yaguang Tang <email address hidden>
Date: Mon Apr 22 17:08:09 2013 +0800

    Remove unnecessary method argument.

    The 'self' argument is unnecessary and when the the method is invoked,
    cause parameters error.

    Fix bug #1171376

    Change-Id: I612b466a955cb8418855849119599222ba6479d3

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/27314

Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/27314
Committed: http://github.com/openstack/nova/commit/c4cd98cebefe8c002c2bd01a88ba46332e4bbd3f
Submitter: Jenkins
Branch: stable/grizzly

commit c4cd98cebefe8c002c2bd01a88ba46332e4bbd3f
Author: Yaguang Tang <email address hidden>
Date: Mon Apr 22 17:08:09 2013 +0800

    Remove unnecessary method argument.

    The 'self' argument is unnecessary and when the the method is invoked,
    cause parameters error.

    Fix bug #1171376

    Change-Id: I612b466a955cb8418855849119599222ba6479d3
    (cherry picked from commit 588aa3625da1272a1225e01ddd0f70d02f7beac9)

Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.