python-neutronclient

pep8 test fails with pyflakes 0.7

Bug #1170639 reported by Roman Podoliaka on 2013-04-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	python-neutronclient	Fix Released	Undecided	Roman Podoliaka	python-neutronclient 2.2.1-2.2.6

Bug Description

pyflakes 0.7 supports checking of doctests. This makes our pep8 test fail because of the following lines in quantumclient/v2.0/client.py comment:

Example::

        >>> from quantumclient.v2_0 import client
        >>> quantum = client.Client(username=USER,
                                     password=PASS,
                                     tenant_name=TENANT_NAME,
                                     auth_url=KEYSTONE_URL)

>>> nets = quantum.list_networks()
...

This looks like a doctest, but it's not. It's better to format this as an ordinary comment to make pep8 test pass.

Tags:

Roman Podoliaka (rpodolyaka) on 2013-04-19

Changed in python-quantumclient:
assignee:	nobody → Roman Podolyaka (rpodolyaka)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-04-19: Fix proposed to python-quantumclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27162

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-04-21: Fix merged to python-quantumclient (master)

Reviewed: https://review.openstack.org/27162
Committed: http://github.com/openstack/python-quantumclient/commit/b971ef0e3b3a757846667f66b4c96d54bb66d568
Submitter: Jenkins
Branch: master

commit b971ef0e3b3a757846667f66b4c96d54bb66d568
Author: Roman Podolyaka <email address hidden>
Date: Fri Apr 19 12:33:31 2013 +0300

Fix a comment formatting to make pep8 test pass

    New version of pyflakes does checking of doctests. We have a
    comment that looks like a doctest, but in fact it's not. This
    makes pep8 test fail.

Fixes bug 1170639.

Change-Id: Iee4f1bb8fd8284c6d1bb0111e23a61f434f3f457