Worker should catch if Swift not enabled for customer log archiving

Bug #1170110 reported by David Shrewsbury
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libra
Fix Released
Medium
David Shrewsbury

Bug Description

Swift archiving code in haproxy driver should do a better job of catching and identifying errors, like when Swift isn't available for a given set of auth credentials. Right now, we get a Python Exception thrown that isn't helpful:

2013-04-17 15:55:55,799: libra_worker - ERROR - ARCHIVE failed: <type 'exceptions.AttributeError'>, 'NoneType' object has no attribute 'find'

Tags: worker
Revision history for this message
David Shrewsbury (dshrews) wrote :

NOTE: This NoneType exception is being thrown by the Swift API library.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to libra (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27129

Changed in libra:
assignee: nobody → David Shrewsbury (dshrews)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to libra (master)

Reviewed: https://review.openstack.org/27129
Committed: http://github.com/stackforge/libra/commit/9bfa04a7284414f9075b36ad5565be59c4361872
Submitter: Jenkins
Branch: master

commit 9bfa04a7284414f9075b36ad5565be59c4361872
Author: David Shrewsbury <email address hidden>
Date: Thu Apr 18 14:46:39 2013 -0400

    Catch Swift exc's and better container handling.

    Fixes bug 1170110

    If Swift were not enabled for a given set of user credentials,
    the Swift API would throw non-descriptive exceptions. We catch
    those with this change and provide a somewhat better error.

    Also, container creation is handled much better. Before, we were
    creating empty objects within a container. Now, we create the
    container and the object we put is named with the LB ID.

    Change-Id: Ieae5de4e50913bb2dea9b9ea501f5fbcb47c5104

Changed in libra:
status: In Progress → Fix Committed
Changed in libra:
status: Fix Committed → Fix Released
milestone: none → 2.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to libra (release-v2)

Fix proposed to branch: release-v2
Review: https://review.openstack.org/27767

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to libra (release-v2)

Reviewed: https://review.openstack.org/27767
Committed: http://github.com/stackforge/libra/commit/8f2aaf4df6dad8ef3b8a32c6c447d7388d97456a
Submitter: Jenkins
Branch: release-v2

commit 8f2aaf4df6dad8ef3b8a32c6c447d7388d97456a
Author: David Shrewsbury <email address hidden>
Date: Thu Apr 18 14:46:39 2013 -0400

    Catch Swift exc's and better container handling.

    Fixes bug 1170110

    If Swift were not enabled for a given set of user credentials,
    the Swift API would throw non-descriptive exceptions. We catch
    those with this change and provide a somewhat better error.

    Also, container creation is handled much better. Before, we were
    creating empty objects within a container. Now, we create the
    container and the object we put is named with the LB ID.

    Change-Id: Ieae5de4e50913bb2dea9b9ea501f5fbcb47c5104

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.