fix(storage.mongodb) Empty bulk insert fails

[Kurt Griffiths]

Repo:

http://166.78.143.130/v1/1874/queues/alerts/messages -H "Client-ID: Foo" -d '{}' -v

Expected:

400 status returned to client

Actual:

Traceback (most recent call last):
  File "api.py", line 83, in falcon.api.API.__call__ (falcon/api.c:1370)
  File "/home/marconi/marconi-app/marconi/transport/wsgi/messages.py", line 53, in on_post
    client_uuid=uuid)
  File "/home/marconi/marconi-app/marconi/storage/mongodb/controllers.py", line 302, in post
    self._col.insert(denormalizer(messages), manipulate=False)
  File "/usr/local/lib/python2.7/dist-packages/pymongo/collection.py", line 357, in insert
    continue_on_error, self.__uuid_subtype), safe)
pymongo.errors.InvalidOperation: cannot do an empty bulk insert

[Flavio Percoco (flaper87)]

Addressed here: https://review.openstack.org/#/c/28984/

[Malini Kamalambal (malini-pk)]

Tested with the latest code & the original issue still exists.

3-05-22 11:51:37.130 4191 ERROR marconi.transport.wsgi.messages [-] cannot do an empty bulk insert
2013-05-22 11:51:37.130 4191 TRACE marconi.transport.wsgi.messages Traceback (most recent call last):
2013-05-22 11:51:37.130 4191 TRACE marconi.transport.wsgi.messages File "/Users/malini.kamalambal/marconi/marconi/transport/wsgi/messages.py", line 51, in on_post
2013-05-22 11:51:37.130 4191 TRACE marconi.transport.wsgi.messages client_uuid=uuid)
2013-05-22 11:51:37.130 4191 TRACE marconi.transport.wsgi.messages File "/Users/malini.kamalambal/marconi/marconi/storage/mongodb/controllers.py", line 329, in post
2013-05-22 11:51:37.130 4191 TRACE marconi.transport.wsgi.messages ids = self._col.insert(denormalizer(messages))
2013-05-22 11:51:37.130 4191 TRACE marconi.transport.wsgi.messages File "/Library/Python/2.7/site-packages/pymongo-2.5-py2.7-macosx-10.7-intel.egg/pymongo/collection.py", line 357, in insert

[Kurt Griffiths (kgriffs)]

I'm on it.

[Kurt Griffiths (kgriffs)]

Hmm. Are you sure you have the latest code? I am unable to repro from a unit test.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/30148

[Kurt Griffiths (kgriffs)]

OK, I've got a repo now added to the unit tests. Turns out it is only with an empty list of messages "[]" and only with the mongodb driver. Sending "{}" works as expected.

[Kurt Griffiths (kgriffs)]

Fix is ready, just needs to be approved.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/30148
Committed: http://github.com/stackforge/marconi/commit/662ea8096ae5e69c456d19c7bb32a404e7993705
Submitter: Jenkins
Branch: master

commit 662ea8096ae5e69c456d19c7bb32a404e7993705
Author: kgriffs <email address hidden>
Date: Wed May 22 14:52:54 2013 -0300

    Properly handle message post with an empty iterable.

    Storage drivers expect at least one item in messages iterable,
    so I modified the WSGI driver to check when this is not
    the case and return an error response to the client rather
    than blindly passing the messages generator into the
    driver's post method.

    Fixes: bug #1169838

    Change-Id: Ia2e512138a465af70110d88e8e11ae58ee5e4aab