Needs to remove class-based import in unit tests

Bug #1167901 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Low
Akihiro Motoki

Bug Description

The unit tests in python-quantumclient use many class-based imports like:

tests/unit/test_cli20_network.py
from quantumclient.quantum.v2_0.network import CreateNetwork
from quantumclient.quantum.v2_0.network import DeleteNetwork
from quantumclient.quantum.v2_0.network import ListExternalNetwork
from quantumclient.quantum.v2_0.network import ListNetwork
from quantumclient.quantum.v2_0.network import ShowNetwork
from quantumclient.quantum.v2_0.network import UpdateNetwork
from quantumclient import shell
from tests.unit import test_cli20
from tests.unit.test_cli20 import CLITestV20Base
from tests.unit.test_cli20 import MyApp

OpenStack projects generally use module level import.

Akihiro Motoki (amotoki)
description: updated
Revision history for this message
Yeukhon (yeukhon) wrote :

Hi. I am new to OpenStack so I am trying to look at bug tickets. Are you proposing we use full path?

According to this and many other code:
https://github.com/openstack/python-quantumclient/blob/master/quantumclient/quantum/v2_0/agentscheduler.py

The import looks okay. Am I wrong?

Akihiro Motoki (amotoki)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-quantumclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/29881

Changed in python-quantumclient:
status: New → In Progress
Changed in python-quantumclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-quantumclient (master)

Reviewed: https://review.openstack.org/29881
Committed: http://github.com/openstack/python-quantumclient/commit/b5a416ac344160512f95751ae16e6612aefd4a57
Submitter: Jenkins
Branch: master

commit b5a416ac344160512f95751ae16e6612aefd4a57
Author: Akihiro MOTOKI <email address hidden>
Date: Tue May 21 15:56:26 2013 +0900

    Remove class-based import in the code repo

    Fixes bug 1167901

    This commit also removes backslashes for line break.

    Change-Id: Id26fdfd2af4862652d7270aec132d40662efeb96

Changed in python-quantumclient:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
milestone: none → 2.2.1-2.2.6
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.