Improve checking or return values for functions in linuxbridge agent plugin

Bug #1167780 reported by Tomasz Paszkowski
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Sandhya Dasu

Bug Description

During review process for:

https://review.openstack.org/#/c/26516

we have found that we can improve checking of return values in the following functions:

- ensure_local_bridge
- ensure_vlan

Tags: linuxbridge
summary: Improve checking or return values for functions in linuxbridge agent
- plugin !
+ plugin
tags: added: linuxbridge
Changed in quantum:
importance: Undecided → Medium
status: New → Confirmed
Sandhya Dasu (sadasu)
Changed in quantum:
assignee: nobody → Sandhya Dasu (sadasu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27847

Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
Sandhya Dasu (sadasu) wrote :

ensure_bridge() returns False or None but most functions calling ensure_bridge() donot check if it returned False. Adding these checks as part of this change although not mentioned in the original bug description.

Changed in quantum:
milestone: none → havana-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/27847
Committed: http://github.com/openstack/quantum/commit/fa69228606ff42233a3f241a455157e675d398df
Submitter: Jenkins
Branch: master

commit fa69228606ff42233a3f241a455157e675d398df
Author: sadasu <email address hidden>
Date: Thu Apr 25 16:05:22 2013 -0400

    Improve checking of return values for functions in linuxbridge agent plugin

    Fixes bug 1167780

    Changed return values for some ensure_* functions to make them more consistent.
    Now all ensure_* functions return None on failure and return the entity that was
    created within the function when successful. Made changes to the unit tests to
    reflect the changed return values.

    Change-Id: Ib015ee7cee50bae5d91a4e109e7381519c1e14f7

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.