Powervm virt driver not reporting correct error state of corrupted VMs

[David Peraza]

power_state mapping in powervm driver is incomplete resulting in VMs that are not able to boot reporting good state to compute manager.

Very simple to recreate: simply add a corrupted powervm image to glance (I used a gzipped text file with raw extensions) and spawn the image. The result is that nova list show instance as available when in reality image is in Error or Open Firmware state.

Recommended fix: Add a complete mapping from powervm power_state to nova compute power_state. Image to device copy can use some debug statements too to make it easier for a user to determine why instance is not booting.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/26528

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/26528
Committed: http://github.com/openstack/nova/commit/1cb4fec1c95f03548ac3a5e9b1b47b3e4012109d
Submitter: Jenkins
Branch: master

commit 1cb4fec1c95f03548ac3a5e9b1b47b3e4012109d
Author: David Peraza <email address hidden>
Date: Tue Apr 9 01:09:13 2013 +0000

    Completes the power_state mapping from compute driver and manager

    Fixes bug 1166906

    Added extra states to constants module together with test
    cases checking every state map.

    Also added some debug statements under blockdev and operator
    to be able to spot obvious issues with images at deploy time.

    Change-Id: I77ebb4d417a3875b761f5fb220d9274b79611ff0