Use Granite About dialog

[Cassidy James Blaede]

You should use Granite's About dialog instead of the GNOME one for consistency sake. This also gives you a help item inside the dialog instead of needing another item in the AppMenu.

[Jaap Broekhuizen (jaapz-b)]

You need to use Granite.Application too if you want to use the Granite.Widgets.AboutDialog to it's full extent, which I don't yet really know how to do in python yet.

[dkotrada (dkotrada)]

TODO: Some example code and resources to look

https://gist.github.com/vkolev/3738745
https://plus.google.com/115885844238353179036/posts/CAnNL4muh21 http://ompldr.org/vZ3FqMQ
https://gist.github.com/zodman/4069349

[Jaap Broekhuizen (jaapz-b)]

I think this will be easier to implement if you ditch Glade based ui and build the ui in python.

[dkotrada (dkotrada)]

You mean PyGTK ? There are no GTK3 support as I know.

[dkotrada (dkotrada)]

Here is the code for granite version where I am able to start an empty granite dialog. So far https://code.launchpad.net/~dkotrada/+junk/granite

[Jaap Broekhuizen (jaapz-b)]

Not PyGTK, but the Gtk from gi.repository :)
And don't put your subclass of Application in AboutDialog.py.
The Application should be the center of your app, so if i were you i'd put your class Application(Granite.Application) in pomidor/__init__.py, and instantiate it in main().

Look at how it is done in Vala apps, it is very similar to that.

[Jaap Broekhuizen (jaapz-b)]

Maybe you should implement this in a new branch, then you can do a merge request to the main branch, and i can review your code :)

[dkotrada (dkotrada)]

I'll use this branch: https://code.launchpad.net/~dkotrada/+junk/granite

Thank you I'll try to put it in __init__.py

2013/4/25 Jaap Broekhuizen <email address hidden>

> Maybe you should implement this in a new branch, then you can do a merge
> request to the main branch, and i can review your code :)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1166026
>
> Title:
> Use Granite About dialog
>
> Status in Pomidor Time Manager:
> New
>
> Bug description:
> You should use Granite's About dialog instead of the GNOME one for
> consistency sake. This also gives you a help item inside the dialog
> instead of needing another item in the AppMenu.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/pomidor/+bug/1166026/+subscriptions
>