allow references to COs from controller Scripts

[Daniel Schürmann]

Currently every read and write of a control object from controller script requires a hash tale lookup.

This could be avoided if we allow to strore references to control objects inside the scripts.

ControlerScript.channel1_play = channel enginge.getControlObject("[Channel1]", play);
ControlerScript.channel1_play.setValue(1);

[Daniel Schürmann (daschuer)]

See https://bugs.launchpad.net/mixxx/+bug/1184581 for a benchmark.

[RJ Skerry-Ryan (rryan)]

This is probably worthwhile (because if you have two equivalent choices to
do something, it may as well be the faster way) to do but very low impact
as the hash table lookup is likely a miniscule fraction of the total time
spent in the script VM. A benchmark that would be a good motivator for this
change would be time spent executing script tasks before and after the
change, not a raw benchmark of getControl (as it's somewhat obvious a hash
table lookup is slower than a variable reference).

On Sun, Oct 13, 2013 at 2:43 PM, Daniel Schürmann <
<email address hidden>> wrote:

> See https://bugs.launchpad.net/mixxx/+bug/1184581 for a benchmark.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1166016
>
> Title:
> allow references to COs from controller Scripts
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1166016/+subscriptions
>

[Daniel Schürmann (daschuer)]

That's why i have reported it. I was impressed that the speedup is "only" 3.

A solution for this bug may increase the complexity of controller scripts, for a relative small improvement for a casual tasks.
(Happens only on button press). I am afraid no one will ever notice the change.
So we should first fix https://bugs.launchpad.net/mixxx/+bug/1184581 to one hashtable lookup and then focus on scratch improvement.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6981