Passing duplicate network ids to Quantum throws wrong exception

Bug #1165088 reported by Ben Nemec
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Ben Nemec
Grizzly
Fix Released
Low
Vish Ishaya

Bug Description

With Nova configured to use Quantum, when I run the following boot command: nova boot test --image cirros-0.3.1-x86_64-uec --flavor 1 --nic net-id=48ce5a27-f9ae-4662-948a-c5cec88a1b5a --nic net-id=48ce5a27-f9ae-4662-948a-c5cec88a1b5a

I get the following exception from nova-api: NetworkNotFound: Network could not be found.

This is not correct. I believe the correct exception in this case is NetworkDuplicated.

Ben Nemec (bnemec)
Changed in nova:
assignee: nobody → Ben Nemec (bnemec)
Ben Nemec (bnemec)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/26246

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/26246
Committed: http://github.com/openstack/nova/commit/8eadd2aee9086815f9fe600d1e2d26145d7b5c16
Submitter: Jenkins
Branch: master

commit 8eadd2aee9086815f9fe600d1e2d26145d7b5c16
Author: Ben Nemec <email address hidden>
Date: Fri Apr 5 16:48:01 2013 +0000

    Raise correct exception for duplicate networks

    When using Quantum, if duplicate network ids are passed in on a
    nova boot, nova-api raises a NetworkNotFound exception, which is
    not correct. This change causes it to raise a NetworkDuplicated
    exception instead.

    Fixes bug 1165088

    Change-Id: I4f1f9aa5e1fa0e740b78e67760d924e2dd1d4d98

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/27286

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/27286
Committed: http://github.com/openstack/nova/commit/c7a0d74642099c4e52d8c3e0ade77cc0930b4f55
Submitter: Jenkins
Branch: stable/grizzly

commit c7a0d74642099c4e52d8c3e0ade77cc0930b4f55
Author: Ben Nemec <email address hidden>
Date: Fri Apr 5 16:48:01 2013 +0000

    Raise correct exception for duplicate networks

    When using Quantum, if duplicate network ids are passed in on a
    nova boot, nova-api raises a NetworkNotFound exception, which is
    not correct. This change causes it to raise a NetworkDuplicated
    exception instead.

    Fixes bug 1165088

    Change-Id: I4f1f9aa5e1fa0e740b78e67760d924e2dd1d4d98
    (cherry picked from commit 8eadd2aee9086815f9fe600d1e2d26145d7b5c16)

Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.