eventlet monkey patches getaddrinfo if dnspython is installed

Bug #1164822 reported by Michael Still
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Michael Still
OpenStack Identity (keystone)
Invalid
High
Unassigned

Bug Description

But the monkeypatched version doesn't support IPv6 very well. We should disable this monkey patch.

Tags: ops
Michael Still (mikal)
summary: - eventlet monkey patches getaddrinfo is dnspython is installed
+ eventlet monkey patches getaddrinfo if dnspython is installed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/26189

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/26325

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/26325
Committed: http://github.com/openstack/nova/commit/f2e49ad3128856785f6ea460b1968bf03dc87e99
Submitter: Jenkins
Branch: master

commit f2e49ad3128856785f6ea460b1968bf03dc87e99
Author: Michael Still <email address hidden>
Date: Mon Apr 8 07:46:34 2013 +1000

    Import eventlet in __init__.py

    All of this is because if dnspython is present in your environment then
    eventlet monkeypatches socket.getaddrinfo() with an implementation
    which doesn't work for IPv6. To turn this off you need to set an
    environment variable before you do the import.

    Resolves bug 1164822.

    Change-Id: I2382db7b3ac4a2d940e0c45dfe3d48f499de2f16

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
Dolph Mathews (dolph) wrote :

<fungi>: bknudson: dolphm: to catch you up, immediately after swift landed a change in master to start depending on dnspython, keystone master and stable/grizzly unit tests began doing this on centos... http://logs.openstack.org/periodic/periodic-keystone-python26-stable-grizzly-centos6/4/console.html.gz
<fungi>: bknudson: dolphm: note that http://logs.openstack.org/periodic/periodic-keystone-python26-stable-grizzly-centos6/3/console.html.gz passed on the same exact keystone gitsha the night before, and the only difference according to pip freeze was that dnspython was suddenly present

Changed in keystone:
status: New → Confirmed
importance: Undecided → High
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Revision history for this message
Morgan Fainberg (mdrnstm) wrote :

This issue appears to be resolved within Keystone by https://review.openstack.org/#/c/29050/ use of keystone.common.environment should have resolved the issues (same general fix as for nova) seen here.

Revision history for this message
Dolph Mathews (dolph) wrote :

Marking as invalid then, as this was effectively superceded by https://blueprints.launchpad.net/keystone/+spec/extract-eventlet

Changed in keystone:
status: Confirmed → Invalid
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.