Provide graceful fallback from qpid notification errors

Bug #1164681 reported by Ben Nemec
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Ben Nemec
Grizzly
Fix Released
Low
Flavio Percoco

Bug Description

I received a request from a user to allow Glance to continue functioning even if qpid goes down and Glance is configured to use notifications through qpid. Since notifications in Glance are an optional component, that shouldn't be a problem.

Ben Nemec (bnemec)
Changed in glance:
assignee: nobody → Ben Nemec (bnemec)
Revision history for this message
Ben Nemec (bnemec) wrote :

Also, forgot to mention that the qpid test cases in Glance are currently broken. They get skipped by default, which is probably why it wasn't caught before. I'll fix those as part of this too.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/26131

Changed in glance:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/26132

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/26131
Committed: http://github.com/openstack/glance/commit/67805719418ec5ae6afaae2e4ebd304ec93d4d7f
Submitter: Jenkins
Branch: master

commit 67805719418ec5ae6afaae2e4ebd304ec93d4d7f
Author: Ben Nemec <email address hidden>
Date: Thu Apr 4 19:42:55 2013 +0000

    Fix Qpid test cases

    The Qpid notification test cases do not currently pass.
    By default they are skipped because qpid is not part of
    test-requires, so it isn't automatically installed. This fix
    updates the test cases to work correctly, but does not add
    qpid to test-requires because I'm unsure what impacts that
    might have on other platforms.

    This is part of the fix for bug 1164681

    Change-Id: I40757b5de99559b4ff090e0d249f8624c2e2be10

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/26132
Committed: http://github.com/openstack/glance/commit/1e98e108c057914a1e8b2ee2295c80db410b5ffa
Submitter: Jenkins
Branch: master

commit 1e98e108c057914a1e8b2ee2295c80db410b5ffa
Author: Ben Nemec <email address hidden>
Date: Thu Apr 4 19:32:03 2013 +0000

    Gracefully handle qpid errors

    If a qpid error occurs when Glance is sending notifications, the
    qpid connection may not be cleaned up properly. This change catches
    qpid exceptions to allow proper error handling.

    Fixes bug 1164681

    Change-Id: Ica3ef54b958e4efe3932b90d721324e7860b1ea4

Thierry Carrez (ttx)
Changed in glance:
milestone: none → havana-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/50257

tags: added: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/grizzly)

Reviewed: https://review.openstack.org/50257
Committed: http://github.com/openstack/glance/commit/83d1efb88009a24e2e6cba15aaa9cb1fd500f296
Submitter: Jenkins
Branch: stable/grizzly

commit 83d1efb88009a24e2e6cba15aaa9cb1fd500f296
Author: Ben Nemec <email address hidden>
Date: Thu Apr 4 19:32:03 2013 +0000

    Gracefully handle qpid errors

    If a qpid error occurs when Glance is sending notifications, the
    qpid connection may not be cleaned up properly. This change catches
    qpid exceptions to allow proper error handling.

    Fixes bug 1164681

    Conflicts:
     glance/tests/unit/test_notifier.py

    (cherry picked from commit 1e98e108c057914a1e8b2ee2295c80db410b5ffa)
    Change-Id: Ica3ef54b958e4efe3932b90d721324e7860b1ea4

Thierry Carrez (ttx)
Changed in glance:
milestone: havana-1 → 2013.2
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential
Changed in glance:
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.