libvirt livemigration warning logger refernces a not defined local variable

Bug #1164072 reported by Attila Fazekas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Michael Still
Grizzly
Fix Released
Medium
Vish Ishaya

Bug Description

2013-04-03 19:45:56.433 7807 TRACE nova.compute.manager [instance: db05a638-846f-41cc-b013-e2e352e707d0] KeyError: u'u\'hostname\'\nTraceback (most recent call last):\n\n File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/amqp.py", line 430, in _process_data\n rval = self.proxy.dispatch(ctxt, version, method, **args)\n\n File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/dispatcher.py", line 133, in dispatch\n return getattr(proxyobj, method)(ctxt, **kwargs)\n\n File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 3071, in pre_live_migration\n migrate_data)\n\n File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 3201, in pre_live_migration\n % locals())\n\nKeyError: u\'hostname\'\n'
2013-04-03 19:45:56.433 7807 TRACE nova.compute.manager [instance: db05a638-846f-41cc-b013-e2e352e707d0]
2013-04-03 19:45:58.036 ERROR nova.openstack.common.rpc.amqp [req-8a1d4d7f-8bff-4e57-b57c-dc4698f5c25c 6787bedca8804cd7b204748d0240235c 4251d38a5827440299d71e3b3d78350b] Exception during message handling
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp Traceback (most recent call last):
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/amqp.py", line 430, in _process_data
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp rval = self.proxy.dispatch(ctxt, version, method, **args)
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/dispatcher.py", line 133, in dispatch
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp return getattr(proxyobj, method)(ctxt, **kwargs)
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 3115, in live_migration
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp block_migration, migrate_data)
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp self.gen.next()
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 3108, in live_migration
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp block_migration, disk, dest, migrate_data)
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/compute/rpcapi.py", line 408, in pre_live_migration
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp version='2.21')
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/proxy.py", line 80, in call
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp return rpc.call(context, self._get_topic(topic), msg, timeout)
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/__init__.py", line 140, in call
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp return _get_impl().call(CONF, context, topic, msg, timeout)
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/impl_qpid.py", line 610, in call
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp rpc_amqp.get_connection_pool(conf, Connection))
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/amqp.py", line 613, in call
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp rv = list(rv)
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/amqp.py", line 562, in __iter__
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp raise result
2013-04-03 19:45:58.036 7807 TRACE nova.openstack.common.rpc.amqp KeyError: u'u\'hostname\'\nTraceback (most recent call last):\n\n File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/amqp.py", line 430, in _process_data\n rval = self.proxy.dispatch(ctxt, version, method, **args)\n\n File "/usr/lib/python2.7/site-packages/nova/openstack/common/rpc/dispatcher.py", line 133, in dispatch\n return getattr(proxyobj, method)(ctxt, **kwargs)\n\n File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 3071, in pre_live_migration\n migrate_data)\n\n File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 3201, in pre_live_migration\n % locals())\n\nKeyError: u\'hostname\'\n'

https://github.com/openstack/nova/blob/2ee1c3d9f5342a135d422afcc7ea45264d232d2c/nova/virt/libvirt/driver.py#L3206

Changed in nova:
importance: Undecided → Medium
status: New → Triaged
tags: added: grizzly-backport-potential low-hanging-fruit
Michael Still (mikal)
Changed in nova:
assignee: nobody → Michael Still (mikalstill)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/26150

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/26150
Committed: http://github.com/openstack/nova/commit/676b16bfe5ff41eb28d782c888c17dae6bdff76a
Submitter: Jenkins
Branch: master

commit 676b16bfe5ff41eb28d782c888c17dae6bdff76a
Author: Michael Still <email address hidden>
Date: Fri Apr 5 08:57:35 2013 +1100

    Fix error message in pre_live_migration.

    We are using locals() to reference a variable which doesn't exist
    in this error message. Also rename the instance variable while I
    am here to be more consistent with other uses.

    Resolves bug 1164072.

    Change-Id: I96f5e2a81ac2e97181c3e87df83e19b381f4bcd2

Changed in nova:
status: In Progress → Fix Committed
tags: removed: grizzly-backport-potential low-hanging-fruit
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/26877

Michael Still (mikal)
summary: libvirt livemigration warning logger refernces a not defined local
- varaible
+ variable
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/26877
Committed: http://github.com/openstack/nova/commit/a3cc7bc231d4da8469e163ccf276a5b95217bb15
Submitter: Jenkins
Branch: stable/grizzly

commit a3cc7bc231d4da8469e163ccf276a5b95217bb15
Author: Michael Still <email address hidden>
Date: Fri Apr 5 08:57:35 2013 +1100

    Fix error message in pre_live_migration.

    We are using locals() to reference a variable which doesn't exist
    in this error message. Also rename the instance variable while I
    am here to be more consistent with other uses.

    Resolves bug 1164072.

    Change-Id: I96f5e2a81ac2e97181c3e87df83e19b381f4bcd2
    (cherry picked from commit 676b16bfe5ff41eb28d782c888c17dae6bdff76a)

Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.