Unclear behavior in V1 API when deleting a pending_delete image

[James Li]

Glance version: Grizzly-rc1

'delay_delete' is ON in the following tests.

v1 api behavior

1st deletion:
- image status changes to 'pending_delete'
- Delete metadata (marked as deleted)
- return 200 - OK

2nd deletion:
- image status changes to 'deleted'.
- But still leave the image data for scrubber to delete.
- return 200- OK

3rd deletion:
- image status is still 'deleted'
- still leave the image data for scrubber to delete.
- return 403 - Forbidden

v2 api behavior

1st deletion:
- status changes to pending_delete
- return 204 No Content

2nd deletion
- status is still pending_delete
- return 404 Not Found

3rd deletion
- status is still pending_delete
- return 404 Not Found

So V2 behavior looks more clear and consistent, however v1 behavior looks vague.

[Mark Washenberger (markwash)]

Thanks for the clear description. It seems like we would get more clarity if the second deletion through v1 returned 403 Forbidden. Do you agree?

[James Li (james-li-3)]

Yeah, I agree. And it makes more sense to me if we don't change the status of the image and just keep it as 'pending_delete' in the 2nd and 3rd deletion of v1.

[James Li (james-li-3)]

I am looking into a fix for it now.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/26802

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/26802
Committed: http://github.com/openstack/glance/commit/cd008483747ff6825131365efc60cd787c36c310
Submitter: Jenkins
Branch: master

commit cd008483747ff6825131365efc60cd787c36c310
Author: James Li <email address hidden>
Date: Thu Apr 11 23:01:45 2013 +0000

    Fix the deletion of a pending_delete image.

    Return '403 - Forbidden' when trying to delete
    a 'pending_delete' image, and does not change
    its status.

    Change-Id: Id5b8b31c19d0f9da8aba66b06d1b966e9c33a363
    Fixes: bug #1163020