It is confusing admin_state_down=False means DOWN

[Akihiro Motoki]

Option admin-state-down is defined as follows.

        parser.add_argument(
            '--admin-state-down',
            default=True, action='store_false',
            help='Set Admin State Up to false')

If this option is specified, parsed_args.admin_state_down is set to False,
ie, admin_state_down=False means admin_state_up is set to False.

It is confusing when reading the code.
it can be easily fixed:

        parser.add_argument(
            '--admin-state-down',
            dest='admin_state', action='store_false',
            help='Set Admin State Up to false')

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/25705

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/25705
Committed: http://github.com/openstack/python-quantumclient/commit/ad7caef9c302575427dfc46cea1c5b84fef8e061
Submitter: Jenkins
Branch: master

commit ad7caef9c302575427dfc46cea1c5b84fef8e061
Author: Akihiro MOTOKI <email address hidden>
Date: Fri Mar 29 03:15:55 2013 +0900

    Change variable name of admin_state_down to admin_state

    It is confusing that admin_state_down=False means admin-state is DOWN.
    It is easy to understand if the variable name matches its value.

    Also removes 'default=xxx' from options with store_true/false action
    since store_true/false sets the default value implicitly.

    Fixes bug 1161853

    Change-Id: I3146dd8974990c94e5f9b3b5bf6a8b28a245d64e