cinder allows creation of volume from snapshot that is larger than specified volume size

[stephen mulcahy]

To reproduce:

1. cinder create 5
2. cinder snapshot-create <volume id from 1>
3. cinder create --snapshot-id <snapshot id from 2> 1

Note that we are creating a 1G volume from a snapshot of a 5G volume

Resulting volume does go to error state but should the api not check the snapshot size when initial request is received and reject it due to invalid size?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/25783

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/25783
Committed: http://github.com/openstack/cinder/commit/cabca4fd3046503bcd917eba0cdd400491ba89cd
Submitter: Jenkins
Branch: master

commit cabca4fd3046503bcd917eba0cdd400491ba89cd
Author: Jean-Baptiste RANSY <email address hidden>
Date: Sat Mar 30 15:25:29 2013 +0100

    Prevent create volume from snapshot with bad size

    Prevent to create a volume from a snapshot with a volume size less
    than the snapshot size.

    Check if a volume size is specified that it is less than
    the snapshot size.

    Raise a exception if it's lesser.

    Fixes bug 1161841

    Change-Id: Ic1afbfb025ce0b3906c35c6c50a71734d74a9851