DeletionPolicy is incorrectly implemented

[Zane Bitter]

We have implemented DeletionPolicy as a Property of the S3 Bucket and Swift Containers resource types. However it is not a Property; it is a top-level attribute (i.e. a sibling of "Properties") of all resources.

The current implementation represents a major incompatibility with AWS templates, which would result in data loss if the user were to create and delete a template with "Retain" deletion policies on the expectation that we have implemented it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/27918

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27918
Committed: http://github.com/openstack/heat/commit/147e1e6afe28e24ef7b508ca7fed0bb0a926b6f0
Submitter: Jenkins
Branch: master

commit 147e1e6afe28e24ef7b508ca7fed0bb0a926b6f0
Author: Thomas Herve <email address hidden>
Date: Wed May 1 16:54:57 2013 +0200

    Make DeletionPolicy a resource attribute instead of a property.

    This improves validation of the different values, and make the Retain
    policy works for all resources.

    Fixes: bug #1160779
    Change-Id: Idb0d275c44661db341f693d9d80629661d66c7ac