libra

Worker services driver should take advantage of sudo_*() methods

Bug #1160548 reported by David Shrewsbury
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libra
Fix Released
Low
David Shrewsbury
libra 2.0

Bug Description

We recently added two new methods to the worker services API:

  sudo_copy()
  sudo_chown()

The code within these functions (maybe just sudo_copy()) is repeated in various places in the ubuntu_services.py implementation. Would be smarter to just make calls to these new methods.

Tags: worker
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to libra (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27174

Changed in libra:
assignee: nobody → David Shrewsbury (dshrews)
status: New → In Progress
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to libra (master)

Reviewed: https://review.openstack.org/27174
Committed: http://github.com/stackforge/libra/commit/20ec25389f7f5055795cb6804f17ddf9405d23b5
Submitter: Jenkins
Branch: master

commit 20ec25389f7f5055795cb6804f17ddf9405d23b5
Author: David Shrewsbury <email address hidden>
Date: Fri Apr 19 10:49:35 2013 -0400

    Cleanup: Remove duplicate file copy code.

    Fixes bug 1160548.

    Just a small cleanup to take advantage of code reuse.

    Change-Id: I6b362335d555a3e384fa8778fcc85cbbdc061fd1

David Shrewsbury (dshrews)
Changed in libra:
status: Fix Committed → Fix Released
milestone: none → 2.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to libra (release-v2)

Fix proposed to branch: release-v2
Review: https://review.openstack.org/27773

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to libra (release-v2)

Reviewed: https://review.openstack.org/27773
Committed: http://github.com/stackforge/libra/commit/7a13c2a704b589afa3b2589b61dad9c3a5a99c82
Submitter: Jenkins
Branch: release-v2

commit 7a13c2a704b589afa3b2589b61dad9c3a5a99c82
Author: David Shrewsbury <email address hidden>
Date: Fri Apr 19 10:49:35 2013 -0400

    Cleanup: Remove duplicate file copy code.

    Fixes bug 1160548.

    Just a small cleanup to take advantage of code reuse.

    Change-Id: I6b362335d555a3e384fa8778fcc85cbbdc061fd1

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.