Nova unit tests spamming log output

Bug #1159978 reported by Russell Bryant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Russell Bryant

Bug Description

The following commit caused a problem with nova unit tests. When you try to run the tests, the log output was being spammed to the console, instead of being caught by the FakeLogger.

commit f665d798234c19cccc148a178e94c3717ba8bd6e
Author: Russell Bryant <email address hidden>
Date: Fri Mar 22 14:10:07 2013 -0400

    Sync everything from oslo-incubator.

    Change-Id: If602b424086abb3edbd4703bc0e3befedbf37925

The specific change from oslo-incubator that cuased this is:

commit 9fe688a412d910e29fdf97fd0f97a7f815db6c8f
Author: Zhiteng Huang <email address hidden>
Date: Wed Mar 13 00:27:48 2013 +0800

    Initialize root logger in _setup_logging_from_conf()

    log.setup() doesn't really initialize root logger, therefore logging
    in 3rd party library such as stevedore doesn't work properly. This
    patch enable root logger initialization.

    Fix bug: # 1073241

    Change-Id: I6fa41b2ba41ff97ad0280f8774a26887d294423e

Changed in nova:
assignee: nobody → Russell Bryant (russellb)
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25320

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/25320
Committed: http://github.com/openstack/nova/commit/d6a9d38a0b7488dd77d3a01ae9c4171c271d7314
Submitter: Jenkins
Branch: master

commit d6a9d38a0b7488dd77d3a01ae9c4171c271d7314
Author: Russell Bryant <email address hidden>
Date: Mon Mar 25 18:05:02 2013 -0400

    set up FakeLogger for root logger.

    A recent change in openstack.common.log was made such that it
    initialized the root logger instead of the project specific logger,
    'nova' in this case. Update the unit tests for this to fix the problem
    where unit tests spam the console with log output.

    Fix bug 1159978.

    Change-Id: Id64a5b078b4024c3269086ed5d64940b3a38ddfa

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.