Client: Holds Client Controls Confusing

[Wolf Halton]

Staff-client interface:
On the cancel hold, the language remains confusing. The options after selecting "Cancel Hold" are Cancel or Apply. In this instance, cancel means cancel the action of cancelling, not cancel the hold.
EG 2.3.4
Opensrf 2.1.2
PostgreSQL 9.1
Debian 6 (Squeeze) Kernel 2.6.32-5-amd64

[Kyle Tomita (tomitakyle)]

What if "Cancel" is changed to "Cancel Action" and "Apply" is changed to "Apply Cancellation"?
That way, the two options still start with the same word but provide a better description of the action.

[Jason Stephenson (jstephenson)]

How 'bout just "Cancel" and "Cancel?" That ought to keep them busy.

[Kyle Tomita (tomitakyle)]

I made a quick branch that changes the text to what I had previously suggested. Here is the branch, http://git.evergreen-ils.org/?p=working/Evergreen.git;a=log;h=refs/heads/user/catalystit/lp1159768

I also attached a shot of the cancel hold window.

[Jason Stephenson (jstephenson)]

On a more serious note:

Maybe this should be an "Are you sure you want cancel hold X?" type of dialog with Yes|No button?

[Kathy Lussier (klussier)]

+1 to Jason's suggestion. I had to stop and think when looking at the "Cancel Action" and "Apply Cancellation" options. Jason's solution seems much clearer.

[Kyle Tomita (tomitakyle)]

I agree No/Yes is a lot clearer. The accesskey's also have been changed to "N" and "Y" respectively.

I have updated the branch to reflect Jason's suggestion and also attached a screenshot of the cancel window.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=log;h=refs/heads/user/catalystit/lp1159768

[Jason Stephenson (jstephenson)]

I like the look of that a lot better. I'll add this to my short list of branches to test as soon as I'm done with the query parser testing I'm doing.

[Jason Etheridge (phasefx)]

I like that too. Just be sure to I18N'ize that new string.

[Kyle Tomita (tomitakyle)]

I added the new string as the variable staff.hold_list.cancel_hold_dialog.confirmation and pushed it to the same branch.

I added to the lang.dtd file only. It needs to be translated to the other languages. Is there other places that I would need to add this to for I18N?

[Jason Etheridge (phasefx)]

> I added to the lang.dtd file only. It needs to be translated to the
> other languages. Is there other places that I would need to add this to
> for I18N?

No, that looks good. During the I18N process, en-US/lang.dtd is one
of the files that gets looked at, and its strings get ripped out and
put into a different format and a different file for translators to
work with. If you were to say, add the en-CA locale to an
installation, then a en-CA/lang.dtd file would get created inheriting
your new DTD entity, potentially with a translation.

[Wolf Halton (saphil)]

Jason++ Kyle++

On Thu, Mar 28, 2013 at 10:26 AM, Kyle Tomita <email address hidden> wrote:

> ** Tags added: pullrequest
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1159768
>
> Title:
> Client: Holds Client Controls Confusing
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1159768/+subscriptions
>

--
Wolf Halton
This Apt Has Super Cow Powers - http://sourcefreedom.com
Open-Source Software in Libraries - http://FOSS4Lib.org
Advancing Libraries Together - http://LYRASIS.org
Apache Open Office Developer <email address hidden>

[Jason Stephenson (jstephenson)]

Kyle,

Are you still working on this one? If not, it should probably be assigned to me, since I said I'd have a look at it.

Jason

[Kyle Tomita (tomitakyle)]

Jason,
I am finish with this one. I will try to reassign it to you.

Kyle

[Jason Stephenson (jstephenson)]

This is a small change (in terms of code) and very useful for staff.

I've committed it to master as it works for me.

Thanks, Kyle!