Ubuntu
accountsservice package

Fails to parse /etc/default/locale

Bug #1159290 reported by Gunnar Hjalmarsson on 2013-03-24

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	accountsservice (Ubuntu)	Fix Released	Medium	Gunnar Hjalmarsson

Bug Description

In gnome-control-center 1:3.6.3-0ubuntu14 "Region & Language" was patched so it can be used for setting languages and locales in Ubuntu. When writing to /etc/default/locale, gnome-control-center adds entries without quotes, e.g. LANG=en_US.UTF-8. When accountsservice parses /etc/default/locale, it presupposes entries like LANG="en_US.UTF-8" (which is the way language-selector adds entries). accountsservice should be able to correctly parse both kinds of entries in /etc/default/locale.

Tags:

Gunnar Hjalmarsson (gunnarhj) on 2013-03-24

tags:	added: patch
Changed in accountsservice (Ubuntu):
assignee:	nobody → Gunnar Hjalmarsson (gunnarhj)
importance:	Undecided → Medium
status:	New → In Progress

Revision history for this message

Gunnar Hjalmarsson (gunnarhj) wrote on 2013-03-24:

accountsservice_lp-1159290.diff Edit (23.0 KiB, text/plain)

Revision history for this message

Martin Pitt (pitti) wrote on 2013-03-25:

Thanks for the quote fix! Why does this drop the migration code?

Revision history for this message

Gunnar Hjalmarsson (gunnarhj) wrote on 2013-03-25:

Hi Martin,

Because it's not needed any longer, or? There was some migration code in postinst too, but it was dropped in the Quantal dev. cycle, and Sebastien told me it's typically dropped after an LTS release. In other words, you aren't expected to go from e.g. Oneiric to Raring without upgrade to Precise in between.

Martin Pitt (pitti) on 2013-03-25

Changed in accountsservice (Ubuntu):
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-03-25:

This bug was fixed in the package accountsservice - 0.6.29-1ubuntu7

---------------
accountsservice (0.6.29-1ubuntu7) raring; urgency=low

  * debian/patches/0009-language-tools.patch:
    - Code for migration from ~/.profile to ~/.pam_environment dropped. This
      was done in 12.04 LTS already.
  * debian/patches/0010-set-language.patch:
    - Code for parsing /etc/default/locale made able to deal with both
      quoted and non-quoted entries (LP: #1159290).
    - Code for migration from ~/.profile to ~/.pam_environment dropped. This
      was done in 12.04 LTS already.
    - A couple of memory leaks fixed.
-- Gunnar Hjalmarsson <email address hidden> Sun, 24 Mar 2013 20:33:00 +0100