Enable option to add track's key TrackProperty to the skin

[xorik]

It would be nice, to have ability to add track's key in the skins, like this: http://ompldr.org/vaHV3Yg

[jus (jus)]

This crude patch displays the existing value of a tracks key (TKEY) field in the deck of Deere1280x800-WXGA.
Used the "key" trackproperty and added a tooltip.

Tested with letting Keyfinder determine a key, then writing this one to the TKEY field and loading the track in Mixxx.

[RJ Skerry-Ryan (rryan)]

Yep, that's all you need. Patch LGTM.

[RJ Skerry-Ryan (rryan)]

Er, well that's all you need to just display the track's native key. In the future we're going to need a key widget to show the effective key (i.e. if the pitch is shifted up by 10 semitones, it should display the adjusted key)

[xorik (xor29a)]

Thank you, jus!

[xorik (xor29a)]

Maybe you add this patch to trunk? (without patching Deere1280x800-WXGA)?

[RJ Skerry-Ryan (rryan)]

Yep -- there's no reason this can't go into the 1.11 branch even since no
1.11 skins use it we don't have to worry about the untranslated tooltip.

On Wed, Apr 3, 2013 at 1:04 AM, xorik <email address hidden> wrote:

> Maybe you add this patch to trunk? (without patching
> Deere1280x800-WXGA)?
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1159141
>
> Title:
> Add track's key TrackProperty to the skin
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1159141/+subscriptions
>

[jus (jus)]

Its nice to have this as option for those who need it.
At the same time, I prefer not to enable it by default as long as we dont have an intelligent key widget as mentioned in #3.
Commited and added info to the wiki

[RJ Skerry-Ryan (rryan)]

I agree. this is really just for consistency since all track properties
should be available to the TrackProperty widget.

On Fri, Apr 12, 2013 at 4:42 AM, jus <email address hidden> wrote:

> Its nice to have this as option for those who need it.
> At the same time, I prefer not to enable it by default as long as we dont
> have an intelligent key widget as mentioned in #3.
> Commited and added info to the wiki
>
> ** Tags removed: fr
>
> ** Summary changed:
>
> - Add track's key TrackProperty to the skin
> + Enable option to add track's key TrackProperty to the skin
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1159141
>
> Title:
> Enable option to add track's key TrackProperty to the skin
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1159141/+subscriptions
>

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6955