Building WL should check whether gettext is installed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Low
|
Unassigned |
Bug Description
How to reproduce:
1. Verify gettext is not installed.
2. Run ./compile.sh
3. Select "debug". (though likely happens with release too)
4. Select yes to build translations.
5. Wait.
WL builds and the tests run without any problems, however when it reaches the translation section it errors because gettext is not installed.
To avoid this, WL should check for gettext before building similar to how it checks for other dependencies. A complicating factor is that it is possible to build WL without translations. Therefore I don't know if we always want to verify it is present, or make it an optional requirement like doxygen. It also seems rather hard to see if the user want to build translations since compile.sh seem to just run `make lang` afterwards which is not something I believe the first build steps will be able to "see".
(Low importance because presumably most people will install all dependencies listed in the wiki)
Related branches
- SirVer: Approve
-
Diff: 376 lines (+11/-68)11 files modifiedCMakeLists.txt (+8/-13)
doc/sphinx/source/compiling.rst (+3/-2)
src/graphic/graphic.cc (+0/-16)
src/graphic/render/gamerenderer_gl.cc (+0/-2)
src/graphic/render/gamerenderer_gl.h (+0/-2)
src/graphic/surface.cc (+0/-4)
src/graphic/texture.cc (+0/-4)
src/graphic/texture.h (+0/-4)
src/ui_fsmenu/options.cc (+0/-7)
src/wlapplication.cc (+0/-12)
src/wui/mapview.cc (+0/-2)
Changed in widelands: | |
milestone: | none → build18-rc1 |
status: | Confirmed → Fix Committed |
In mac, wl doesn't compile because gettext.h and libintl are not found without gettext.
Also, we do not check for glew, though we use it in some places.