OpenStack Compute (nova)

don't log rpc timeout in rpc layer

Bug #1158920 reported by Russell Bryant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Russell Bryant
OpenStack Compute (nova) 2013.1 "grizzly"

Bug Description

The rpc layer should let the caller handle the timeout and decide how and if it should be logged. This is similar to 1137994, but removing the exception logging from the rpc layer was never done.

Russell Bryant (russellb)
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Russell Bryant (russellb)
milestone: none → grizzly-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25165

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/25165
Committed: http://github.com/openstack/nova/commit/132a0c1fd1eb127e393e5794ffa6d4a3a4950567
Submitter: Jenkins
Branch: master

commit 132a0c1fd1eb127e393e5794ffa6d4a3a4950567
Author: Russell Bryant <email address hidden>
Date: Fri Mar 22 13:59:14 2013 -0400

    Don't log traceback on rpc timeout.

    Don't log a traceback in the rpc layer after a timeout() occurs while
    waiting on a response to a call(). Let the caller get the exception and
    decide whether it should be logged or not.

    Fix bug 1158920.

    Change-Id: I0387ab48899627cbc3eb1d7187067472ddefc1bf

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25440

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (milestone-proposed)

Reviewed: https://review.openstack.org/25440
Committed: http://github.com/openstack/nova/commit/f5b03f45d6cd8b19f19ee20c2b6b4d114d3a4d1c
Submitter: Jenkins
Branch: milestone-proposed

commit f5b03f45d6cd8b19f19ee20c2b6b4d114d3a4d1c
Author: Russell Bryant <email address hidden>
Date: Fri Mar 22 13:59:14 2013 -0400

    Don't log traceback on rpc timeout.

    Don't log a traceback in the rpc layer after a timeout() occurs while
    waiting on a response to a call(). Let the caller get the exception and
    decide whether it should be logged or not.

    Fix bug 1158920.

    Change-Id: I0387ab48899627cbc3eb1d7187067472ddefc1bf
    (cherry picked from commit 132a0c1fd1eb127e393e5794ffa6d4a3a4950567)

Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.