nova compute trying to access db on resize

[Lance Bragstad]

There is a case where a user tries to auto-confirm a resize using resize_confirm_window configuration option in nova config, set to N seconds since the instance is in 'resize_verify' state.

The auto-confirmation fails because nova-compute is trying to access the database directly, instead of using nova-conductor to access the database to get the new and old instance types.

Stace Trace: http://pastebin.com/aGFduxSk

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/25179

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/25179
Committed: http://github.com/openstack/nova/commit/5908b60b0420f1ad528e56b0c147a330e9a1a5d6
Submitter: Jenkins
Branch: master

commit 5908b60b0420f1ad528e56b0c147a330e9a1a5d6
Author: Dan Smith <email address hidden>
Date: Fri Mar 22 12:57:59 2013 -0700

    Make _downsize_quota_delta() use stashed instance types

    This change changes the _downsize_quota_delta() method to take instance
    as a param instead of migration_ref, and use it to extract the old and new
    instance_types instead of looking them up in the database. This is needed
    for this case since the method can be called from compute manager during
    the periodic task to confirm pending migrations, and thus access to the
    database may not be allowed.

    Fixes bug #1158897

    Change-Id: I647c51bc4d30e6dfd62abe7b65a9109d6aa2bb6f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25272

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/25272
Committed: http://github.com/openstack/nova/commit/040640cbfb741207a793b790526369f63dd1775f
Submitter: Jenkins
Branch: milestone-proposed

commit 040640cbfb741207a793b790526369f63dd1775f
Author: Dan Smith <email address hidden>
Date: Fri Mar 22 12:57:59 2013 -0700

    Make _downsize_quota_delta() use stashed instance types

    This change changes the _downsize_quota_delta() method to take instance
    as a param instead of migration_ref, and use it to extract the old and new
    instance_types instead of looking them up in the database. This is needed
    for this case since the method can be called from compute manager during
    the periodic task to confirm pending migrations, and thus access to the
    database may not be allowed.

    Fixes bug #1158897

    Change-Id: I647c51bc4d30e6dfd62abe7b65a9109d6aa2bb6f