ip netns exec <netns> kill <pid> doesn't make sense

Bug #1158589 reported by Isaku Yamahata
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Isaku Yamahata

Bug Description

There are several code which executes
ip netns exec <netns> kill <pid>

Since pidns is different from netns, it doesn't make sense. Just kill <pid> works.
As side effects, 'ip netns exec' referes /var/run/netns/<netns> which is bind-mounted to
/proc/<pid>/ns/net. It makes the corresponding dentry young, which increases the possibility
to fail to delete netns. That's bad.

Changed in quantum:
assignee: nobody → Isaku Yamahata (yamahata)
status: New → In Progress
Changed in quantum:
importance: Undecided → Low
tags: added: l3-ipam-dhcp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25094

tags: added: lbaas
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/25094
Committed: http://github.com/openstack/quantum/commit/4d72093de571c2a12dc12c3761e3bcec11ccf20e
Submitter: Jenkins
Branch: master

commit 4d72093de571c2a12dc12c3761e3bcec11ccf20e
Author: Isaku Yamahata <email address hidden>
Date: Tue Mar 19 06:56:15 2013 +0900

    netns: ip netns exec <name> kill doesn't make sense

    It seems confusing netns with pidns.
    Although 'ip netns exec' doesn't make sense,
    'ip netns exec <netns> kill <pid>' itself success as expected.
    But as side effects, dentry of /proc/<pid>/ns/net becomes young,
    which increases the possibility to fail to delete netns. That's not good.

    Fixes: Bug #1158589
    Change-Id: I9aa717ccb86d8bf00bb1e707d39bfb65d043532b
    Signed-off-by: Isaku Yamahata <email address hidden>

Changed in quantum:
status: In Progress → Fix Committed
Changed in quantum:
milestone: none → havana-1
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.