The LBaaS CLI command required optional arguments order inside the usage help

Bug #1157502 reported by Jason
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Low
Ilya Shakhat

Bug Description

In the LBaaS CLI command lb-healthmonitor-create usage help info,

lb-healthmonitor-create [-h] [-f {shell,table}] [-c COLUMN]
                        [--variable VARIABLE] [--prefix PREFIX]
                        [--request-format {json,xml}]
                        [--tenant-id TENANT_ID] [--admin-state-down]
                        --delay DELAY [--expected-codes EXPECTED_CODES]
                        [--http-method HTTP_METHOD] --max-retries
                        MAX_RETRIES --timeout TIMEOUT --type TYPE
                        [--url-path URL_PATH]

Since the --delay DELAY, --max-retries MAX_RETRIES, --timeout TIMEOUT and --type TYPE are required for creation, it will be better to display the usage help info as:

lb-healthmonitor-create [-h] [-f {shell,table}] [-c COLUMN]
                        [--variable VARIABLE] [--prefix PREFIX]
                        [--request-format {json,xml}]
                        [--tenant-id TENANT_ID] [--admin-state-down]
                        [--expected-codes EXPECTED_CODES]
                        [--http-method HTTP_METHOD]
                        [--url-path URL_PATH]
                        --delay DELAY --max-retries MAX_RETRIES
                        --timeout TIMEOUT --type TYPE

Tags: lbaas
Jason (zzs)
description: updated
description: updated
Jason (zzs)
summary: - The LBaaS CLI help postional argument is incorrect
+ The LBaaS CLI help optional argument usage is confused
Jason (zzs)
summary: - The LBaaS CLI help optional argument usage is confused
+ The LBaaS CLI command usage
information type: Public → Private
Jason (zzs)
description: updated
Changed in quantum:
status: New → Opinion
summary: - The LBaaS CLI command usage
+ The LBaaS CLI command usage help info
Changed in quantum:
assignee: nobody → Ilya Shakhat (shakhat)
affects: quantum → python-quantumclient
tags: added: lbaas
information type: Private → Public
Changed in python-quantumclient:
status: Opinion → New
Jason (zzs)
summary: - The LBaaS CLI command usage help info
+ The LBaaS CLI command required optional arguments order inside the usage
+ help
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-quantumclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24979

Changed in python-quantumclient:
status: New → In Progress
Akihiro Motoki (amotoki)
Changed in python-quantumclient:
importance: Undecided → Low
milestone: none → 2.2.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-quantumclient (master)

Reviewed: https://review.openstack.org/24979
Committed: http://github.com/openstack/python-quantumclient/commit/68ad8f8af72676849ff1c972cd7da17b1fb5757e
Submitter: Jenkins
Branch: master

commit 68ad8f8af72676849ff1c972cd7da17b1fb5757e
Author: Ilya Shakhat <email address hidden>
Date: Thu Mar 21 14:12:40 2013 +0400

    Reordering of optional and required args in lbaas commands help

    In help info required args are changed to go after optional. The change
    affects 'lb-healthmonitor-create' and 'lb-member-create' commands.

    Fixes bug 1157502

    Change-Id: I5bb2337796c8b725333ed23a662061a4f276985c

Changed in python-quantumclient:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.