Cinder

CoraidDriver: typo in _login exception handler

Bug #1157499 reported by Larry Matter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Jean-Baptiste RANSY
Cinder 2013.1 "grizzly"

Bug Description

In cinder/volume/drivers/coraid.py, _login method, if login is unsuccessful, we try to get the message from an undefined object "response". Instead we should be getting it from "reply".

- errmsg = response.get('message', '')
+ errmsg = reply.get('message', '')

Tags: coraid drivers
Larry Matter (lmatter)
Changed in cinder:
assignee: nobody → Larry Matter (lmatter)
status: New → In Progress
John Griffith (john-griffith)
Changed in cinder:
importance: Undecided → High
milestone: none → grizzly-rc2
Larry Matter (lmatter)
Changed in cinder:
assignee: Larry Matter (lmatter) → nobody
Jean-Baptiste RANSY (jean-baptiste-ransy)
Changed in cinder:
assignee: nobody → Jean-Baptiste RANSY (jean-baptiste-ransy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24983

John Griffith (john-griffith)
tags: added: coraid drivers
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/24983
Committed: http://github.com/openstack/cinder/commit/4403230bbe8f39a19c38e58840bbb2283ccd808f
Submitter: Jenkins
Branch: master

commit 4403230bbe8f39a19c38e58840bbb2283ccd808f
Author: Jean-Baptiste RANSY <email address hidden>
Date: Thu Mar 21 11:51:37 2013 +0100

    CoraidDriver: typo in _login exception handler

    In cinder/volume/drivers/coraid.py, _login method, if login is
    unsuccessful, we try to get the message from an undefined
    object "response". Instead we should be getting it from "reply".

    - errmsg = response.get('message', '')
    + errmsg = reply.get('message', '')

    Fixes bug 1157499

    Change-Id: Ifd047ced6b40f49881e81d4e73189d9bd216c903

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25223

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (milestone-proposed)

Reviewed: https://review.openstack.org/25223
Committed: http://github.com/openstack/cinder/commit/9d77ef85b8a58f3bca584c0820eb88f511ba94fb
Submitter: Jenkins
Branch: milestone-proposed

commit 9d77ef85b8a58f3bca584c0820eb88f511ba94fb
Author: Jean-Baptiste RANSY <email address hidden>
Date: Thu Mar 21 11:51:37 2013 +0100

    CoraidDriver: typo in _login exception handler

    In cinder/volume/drivers/coraid.py, _login method, if login is
    unsuccessful, we try to get the message from an undefined
    object "response". Instead we should be getting it from "reply".

    - errmsg = response.get('message', '')
    + errmsg = reply.get('message', '')

    Fixes bug 1157499

    Change-Id: Ifd047ced6b40f49881e81d4e73189d9bd216c903
    (cherry picked from commit 4403230bbe8f39a19c38e58840bbb2283ccd808f)

Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-rc2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.