rpc notifier should be copied into openstack common

Bug #1157126 reported by Ollie Leahy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Walt Boring

Bug Description

If rpc based notifications are enabled on cinder by added the following entry to cincer.conf:

notification_driver = cinder.openstack.common.notifier.rabbit_notifier

Then the following error is generated by bin/cinder-volume-usage-audit

2013-03-19 10:55:52.866 ERROR cinder.openstack.common.notifier.api [req-053bcb4d-9ce3-4f73-91e8-fae69a487f38 None None] Failed to load notifier cinder.openstack.common.notifier.rabbit_notifier. These notifications will not be sent.
2013-03-19 10:55:52.866 TRACE cinder.openstack.common.notifier.api Traceback (most recent call last):
2013-03-19 10:55:52.866 TRACE cinder.openstack.common.notifier.api File "/mnt/stack/cinder/cinder/openstack/common/notifier/api.py", line 170, in add_driver
2013-03-19 10:55:52.866 TRACE cinder.openstack.common.notifier.api driver = importutils.import_module(notification_driver)
2013-03-19 10:55:52.866 TRACE cinder.openstack.common.notifier.api File "/mnt/stack/cinder/cinder/openstack/common/importutils.py", line 58, in import_module
2013-03-19 10:55:52.866 TRACE cinder.openstack.common.notifier.api __import__(import_str)
2013-03-19 10:55:52.866 TRACE cinder.openstack.common.notifier.api File "/mnt/stack/cinder/cinder/openstack/common/notifier/rabbit_notifier.py", line 19, in <module>
2013-03-19 10:55:52.866 TRACE cinder.openstack.common.notifier.api from cinder.openstack.common.notifier import rpc_notifier
2013-03-19 10:55:52.866 TRACE cinder.openstack.common.notifier.api ImportError: cannot import name rpc_notifier
2013-03-19 10:55:52.866 TRACE cinder.openstack.common.notifier.api

I think that the file rpc_notifier.py (and rpc_notifier2.py) should be copied into cinder/openstack/common/notifier

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24774

Changed in cinder:
assignee: nobody → Ollie Leahy (oliver-leahy-l)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/24933

Changed in cinder:
assignee: Ollie Leahy (oliver-leahy-l) → Walt Boring (walter-boring)
Revision history for this message
Walt Boring (walter-boring) wrote :

This patch contains all of the oslo updates except policy.py. We have held policy.py back due to being high risk at this stage and it contains lots of changes since the last update.

https://review.openstack.org/#/c/24933/

Changed in cinder:
milestone: none → grizzly-rc2
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/24933
Committed: http://github.com/openstack/cinder/commit/eae0264782818342c222c18b549e9cda354c867b
Submitter: Jenkins
Branch: master

commit eae0264782818342c222c18b549e9cda354c867b
Author: Walter A. Boring IV <email address hidden>
Date: Wed Mar 20 13:18:12 2013 -0700

    Update Cinder's latest copy of OSLO grizzly stable

    This patch updates all the files from oslo under
    stable/grizzly but policy.py. policy.py is a high risk
    change at this date and it has lots of changes since the
    last time we updated it.

    Fixes bug #1157126

    Change-Id: I399a1cd8474f718ed5196def90d2fea546fb01f5

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25096

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (milestone-proposed)

Reviewed: https://review.openstack.org/25096
Committed: http://github.com/openstack/cinder/commit/d0b9b2721045454bcb076537af97be9b14a1103d
Submitter: Jenkins
Branch: milestone-proposed

commit d0b9b2721045454bcb076537af97be9b14a1103d
Author: Walter A. Boring IV <email address hidden>
Date: Wed Mar 20 13:18:12 2013 -0700

    Update Cinder's latest copy of OSLO grizzly stable

    This patch updates all the files from oslo under
    stable/grizzly but policy.py. policy.py is a high risk
    change at this date and it has lots of changes since the
    last time we updated it.

    Fixes bug #1157126

    Change-Id: I399a1cd8474f718ed5196def90d2fea546fb01f5
    (cherry picked from commit eae0264782818342c222c18b549e9cda354c867b)

Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-rc2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.