libvirt vif get_config interface broken

[Dan Prince]

Using the latest version of Nova Grizzly (git 76c47c1) we seem to have broken the libvirt vif driver interface for the get_config call. I now get the following error when trying to spawn instances w/ SmokeStack:

2013-03-16 09:03:10.886 ERROR nova.compute.manager [req-d77836b7-3b5a-4a78-976a-0cdc0d008957 e7b7a663d1e54dff8a0e380c03b7509f e32ebecb48b64606ba43fda7b52a57b3] [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] Instance failed to spawn
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] Traceback (most recent call last):
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 1055, in _spawn
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] block_device_info)
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 1510, in spawn
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] block_device_info=block_device_info)
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 2327, in to_xml
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] disk_info, rescue, block_device_info)
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 2251, in get_guest_config
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] inst_type)
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] TypeError: get_config() takes exactly 5 arguments (6 given)
2013-03-16 09:03:10.886 24296 TRACE nova.compute.manager [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178]
2013-03-16 09:03:11.581 24296 ERROR nova.virt.libvirt.driver [-] [instance: b1084143-a0ab-42de-a7a8-bd9acac3f178] During wait destroy, instance disappeared.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24576

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24576
Committed: http://github.com/openstack/nova/commit/6031a81fd5e513473e82fb65a46cec56c5613379
Submitter: Jenkins
Branch: master

commit 6031a81fd5e513473e82fb65a46cec56c5613379
Author: Dan Prince <email address hidden>
Date: Sat Mar 16 10:24:20 2013 -0400

    Revert "Remove the usage of instance['extra_specs'

    This reverts commit 76c47c1c3057d5ee479cf1e55b803f5ac9faba1d.

    Fix libvirt vif get_config interface breakage.

    In 76c47c1 we added a new arg to the libvirt vif driver get_config
    interface (instance_type=None). We did not update all the libvirt
    drivers to use it however which can break things badly (instances
    fail to spawn, etc). We clearly need more test coverage here as well.

    This should fix SmokeStack.

    Fixes LP Bug #1155950.

    Change-Id: I073d119ea2bfd5c314d2d8c8bbf2f6d7d649753a