XenServer fails to fetch images

[Dan Prince]

Using the latest Grizzly code (f5a2890 or later).

I see the following in compute.log when trying to boot an instance:

2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] block_device_info=block_device_info)
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] File "/usr/lib/python2.7/site-packages/nova/virt/xenapi/vm_utils.py", line 518, in get_vdis_for_instance
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] context, session, instance, name_label, image, image_type)
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] File "/usr/lib/python2.7/site-packages/nova/virt/xenapi/vm_utils.py", line 974, in _create_image
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] image_id, image_type)
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] File "/usr/lib/python2.7/site-packages/nova/virt/xenapi/vm_utils.py", line 919, in _create_cached_image
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] image_id, image_type)
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] File "/usr/lib/python2.7/site-packages/nova/virt/xenapi/vm_utils.py", line 994, in _fetch_image
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] vdis = _fetch_vhd_image(context, session, instance, image_id)
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] File "/usr/lib/python2.7/site-packages/nova/virt/xenapi/vm_utils.py", line 1109, in _fetch_vhd_image
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] callback=callback)
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] File "/usr/lib/python2.7/site-packages/nova/virt/xenapi/vm_utils.py", line 1034, in _fetch_using_dom0_plugin_with_retry
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] raise exception.CouldNotFetchImage(image_id=image_id)
2013-03-15 20:48:08.670 3203 TRACE nova.utils [instance: 0b039bcf-0d67-41d4-91d3-5624369dc096] CouldNotFetchImage: Could not fetch image 24c88443-07f2-4665-95c7-5717773c7def

---

The issue seems to be caused by commit f5a2890 where we changed our routine to automatically extract OVS images. This seems like a really bad idea because it has *no* compatibility existing images Xenserver uses might have.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24558

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24558
Committed: http://github.com/openstack/nova/commit/7f1b1b69d70a6c7ee37b0f8c907473ddf5c08cac
Submitter: Jenkins
Branch: master

commit 7f1b1b69d70a6c7ee37b0f8c907473ddf5c08cac
Author: Dan Prince <email address hidden>
Date: Fri Mar 15 16:57:47 2013 -0400

    Revert 1154253 causes XenServer image compat issue

    In 1154253 we:

      Drop gzip flag from tar command for OVF archives

    While support more OVF file formats is a worthy goal the approach
    in 1154253 is going to cause serious issues for existing
    Nova XenServer users who are already zipping their OVS images.

    I would also point out that our utils.py xenserver plugins still
    zips tarballs we create (see create_tarball) so the new code
    causes internal inconsistencies as well.

    This should fix SmokeStack.

    Fixes LP Bug #1155783.

    Change-Id: Iff6db314c0dec6df2e48d98db2a547f6624b9d9a