Migration 017 uses internal swift store classes

Bug #1155749 reported by John Bresnahan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
John Bresnahan

Bug Description

This bug came out of https://bugs.launchpad.net/glance/+bug/1025746. They should be solved in separate reviews therefore they should have their own bugs.

Migration 17 imports and accesses classes from the swift driver and overrides internal functions. This means that the migration code must change with the driver code. These should be separate bits of functionality.

Changed in glance:
status: New → Triaged
importance: Undecided → High
tags: added: grizzly-rc-potential
Changed in glance:
assignee: nobody → John Bresnahan (jbresnah)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24656

Changed in glance:
status: Triaged → In Progress
tags: added: grizzly-backport-potential
removed: grizzly-rc-potential
tags: added: grizzly-rc-potential
removed: grizzly-backport-potential
Thierry Carrez (ttx)
Changed in glance:
importance: High → Medium
Thierry Carrez (ttx)
tags: added: grizzly-backport-potential
removed: grizzly-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/24656
Committed: http://github.com/openstack/glance/commit/f1804c443b1c8f825e1cf1d01a72de34cde63841
Submitter: Jenkins
Branch: master

commit f1804c443b1c8f825e1cf1d01a72de34cde63841
Author: John Bresnahan <email address hidden>
Date: Thu Mar 21 15:28:46 2013 -1000

    Remove internal store references from migration 017

    Migration 017 was accessing a object internal to the swift store driver
    and changing its behavior in order to do the migration. This worked but
    it made the assumption that the driver logic would not change without
    also changing the migration code. This patch removes all dependencies on
    the swift driver from the migration code. This patch is smilar to
    https://review.openstack.org/#/c/24552/.

    Fixes bug: 1155749
    Change-Id: Iffd800f62d61bf7608f7be5b23d76d702e6d4064

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: havana-1 → 2013.2
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.