OpenStack Image Registry and Delivery Service (Glance)

Migration 015 should not use internal Glance classes

Reported by Dan Prince on 2012-07-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Medium
John Bresnahan

Bug Description

I recently made some Glance backend storage changes and was a bit surprised I had to change glance/db/sqlalchemy/migrate_repo/versions/015_quote_swift_credentials.py (a database migration) in order for tests to pass.

It would be best if Glance migrations did not rely on internal Glance classes when performing data migrations. If we need access to a backend storage class we should implement an inline version in this migration.

Dan Prince (dan-prince) on 2012-07-17
Changed in glance:
importance: Undecided → Low
assignee: nobody → Dan Prince (dan-prince)
Brian Waldon (bcwaldon) on 2012-07-18
Changed in glance:
status: New → Triaged
Brian Waldon (bcwaldon) on 2012-08-20
Changed in glance:
milestone: none → folsom-rc1
Dan Prince (dan-prince) on 2012-09-04
Changed in glance:
assignee: Dan Prince (dan-prince) → nobody
milestone: folsom-rc1 → none
Mark Washenberger (markwash) wrote :

This also affects 017_quote_encrypted_swift_credentials.py

This is a big deal because the StoreLocation code could easily change, and thus break the expectations being placed on it in migrations. We also don't want to have to prevent beneficial changes in StoreLocation just because they might break migrations.

Changed in glance:
importance: Low → High
milestone: none → grizzly-rc1
Changed in glance:
milestone: grizzly-rc1 → havana-1
Changed in glance:
assignee: nobody → John Bresnahan (jbresnah)

Fix proposed to branch: master
Review: https://review.openstack.org/24552

Changed in glance:
status: Triaged → In Progress
Brian Waldon (bcwaldon) on 2013-03-15
Changed in glance:
milestone: havana-1 → grizzly-rc1
tags: added: grizzly-rc-potential
Changed in glance:
milestone: grizzly-rc1 → none
tags: added: grizzly-backport-potential
removed: grizzly-rc-potential
tags: added: grizzly-rc-potential
removed: grizzly-backport-potential
Thierry Carrez (ttx) on 2013-03-27
Changed in glance:
importance: High → Medium
Thierry Carrez (ttx) on 2013-04-02
tags: added: grizzly-backport-potential
removed: grizzly-rc-potential

Reviewed: https://review.openstack.org/24552
Committed: http://github.com/openstack/glance/commit/62068a3cf9d8803a22f80c0fad7044861d3e3399
Submitter: Jenkins
Branch: master

commit 62068a3cf9d8803a22f80c0fad7044861d3e3399
Author: John Bresnahan <email address hidden>
Date: Fri Mar 15 09:41:26 2013 -1000

    Remove internal store references from migration 015

    Migration 015 was accessing a object internal to the swift store driver
    and changing its behavior in order to do the migration. This worked but
    it made the assumption that the driver logic would not change without
    also changing the migration code. These two should not be dependent
    upon each other. This patch removes all dependencies on swift from the
    migration code.

    Fixes bug: 1025746
    Change-Id: Ic9559ae809b8784d0992cb5275d3911a725110c8

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-05-29
Changed in glance:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in glance:
milestone: havana-1 → 2013.2
Alan Pevec (apevec) on 2014-03-30
tags: removed: grizzly-backport-potential
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers