Some db/sqlalchemy debug messages print sql password

[Tom Hancock]

Some messages in glance/db/sqlalchemy/api.py and glance/db/sqlalchemy/migration print the SQL password to logs
or embed it in exception messages. Simply not using the SQL connection in the text would resolve this.

[Thierry Carrez (ttx)]

Could you be more specific ? Trying to decide if we should embrago the fix or not... Are those messages only activated in debug mode ? Are they user-facing or log-facing only ?

[Tom Hancock (tom-hancock)]

Sure.
The messages are available in non debug mode under error conditions.
I identified five - four are associated with database migrations, the fifth with initialising the connection.
They are printed to log messages and as far as I can tell they're not available to users.

[Michael Still (mikal)]

At the very least we should never log the SQL connection string, which almost certainly contains the DB password.

$ search LOG | grep sql_connection
./migration.py: LOG.info(_("Upgrading %(sql_connection)s to version %(version_str)s") %
./migration.py: LOG.info(_("Downgrading %(sql_connection)s to version %(version)s") %

Tom, are you working on a patch for this or shall I?

[Tom Hancock (tom-hancock)]

See https://review.openstack.org/#/c/24521

[Michael Still (mikal)]

Public code review == public bug. This isn't remotely exploitable, so I don't think we need to hold it too close anyways.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24521
Committed: http://github.com/openstack/glance/commit/8825d3ab3d2ca670bbfe48a8b5575cfdc4231092
Submitter: Jenkins
Branch: master

commit 8825d3ab3d2ca670bbfe48a8b5575cfdc4231092
Author: Tom Hancock <email address hidden>
Date: Fri Mar 15 11:08:35 2013 +0000

    Don't print sql password in debug messages

    Fixes bug #1155603

    Change-Id: I78da6744a0c65211efc3c36593c300cbf685bcfc

[Thierry Carrez (ttx)]

Agree that we don't need to publish an OSSA on this.