Typo in policy.json

[Salvatore Orlando]

The following lines have an extra colon:

"create_qos_queue:": "rule:admin_only",
"get_qos_queue:": "rule:admin_only",
"get_qos_queues:": "rule:admin_only",

As a result the corresponding enforce check (in NVP plugin) checks for admin_or_owner instead of admin_only.

However since there the object to check in passed in the form resource: {<...object..>} the tenant_id attribute is not available to the policy engine (as it's nested in the value of the 'resource' key), and therefore the 'owner' part of the 'admin_or_owner' check always fails.

It looks like we are in that situation where two wrongs make a right, but it's probably worth fixing both of them

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24494

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24494
Committed: http://github.com/openstack/quantum/commit/95f677d7f3d134896b8c216b7f2a5d71cc64cd2f
Submitter: Jenkins
Branch: master

commit 95f677d7f3d134896b8c216b7f2a5d71cc64cd2f
Author: Salvatore Orlando <email address hidden>
Date: Fri Mar 15 01:31:31 2013 +0100

    Fix typo in policy.json and checks in nicira plugin

    Bug 1155379

    This patch removes extra colons from policy.json.
    Also, it fixes some checks in the nicira plugin which were not
    passing correctly the target resource for the policy engine.

    Change-Id: I89a1d170818173eaa90b50158289a06455febadc

[Gary Kotton (garyk)]

The problem does not exist in the milestone-proposed version. I am removing the tag grizzly-backport-potential

[Baodong (Robert) Li (baoli)]

Hi Gary & Dan,

Can you guys take a look at it? I have other stuff depending on this in
order to review/commit, etc. Can't find contacts of other core devstack
developers.

Thanks,
Robert

On 3/18/13 4:38 PM, "Robert Li (baoli)" <email address hidden> wrote:

>Public bug reported:
>
>Currently, lib/quantum supports two config files on the command line:
>quantum config file and core plugin config file. Ideally it should be
>able to support as many as indicated by the plugin script. For example,
>cisco plugin may need to load openvswitch plugin configuration file as
>well.
>
>** Affects: devstack
> Importance: Undecided
> Assignee: Baodong (Robert) Li (baoli)
> Status: New
>
>** Changed in: devstack
> Assignee: (unassigned) => Baodong (Robert) Li (baoli)
>
>--
>You received this bug notification because you are subscribed to the bug
>report.
>https://bugs.launchpad.net/bugs/1156831
>
>Title:
> support multiple config files from cmd line
>
>Status in devstack - openstack dev environments:
> New
>
>Bug description:
> Currently, lib/quantum supports two config files on the command line:
> quantum config file and core plugin config file. Ideally it should be
> able to support as many as indicated by the plugin script. For
> example, cisco plugin may need to load openvswitch plugin
> configuration file as well.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/devstack/+bug/1156831/+subscriptions

[Gary Kotton (garyk)]

Hi,
I'll check it out tomorrow morning. I do not have access to test it at
the moment.
Thanks
Gary

On 04/02/2013 05:59 PM, Baodong (Robert) Li wrote:
> Hi Gary& Dan,
>
> Can you guys take a look at it? I have other stuff depending on this in
> order to review/commit, etc. Can't find contacts of other core devstack
> developers.
>
> Thanks,
> Robert
>
> On 3/18/13 4:38 PM, "Robert Li (baoli)"<email address hidden> wrote:
>
>> Public bug reported:
>>
>> Currently, lib/quantum supports two config files on the command line:
>> quantum config file and core plugin config file. Ideally it should be
>> able to support as many as indicated by the plugin script. For example,
>> cisco plugin may need to load openvswitch plugin configuration file as
>> well.
>>
>> ** Affects: devstack
>> Importance: Undecided
>> Assignee: Baodong (Robert) Li (baoli)
>> Status: New
>>
>> ** Changed in: devstack
>> Assignee: (unassigned) => Baodong (Robert) Li (baoli)
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1156831
>>
>> Title:
>> support multiple config files from cmd line
>>
>> Status in devstack - openstack dev environments:
>> New
>>
>> Bug description:
>> Currently, lib/quantum supports two config files on the command line:
>> quantum config file and core plugin config file. Ideally it should be
>> able to support as many as indicated by the plugin script. For
>> example, cisco plugin may need to load openvswitch plugin
>> configuration file as well.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/devstack/+bug/1156831/+subscriptions