agpFastWrite is always off (ubuntu patch obsolete)

[Tormod Volden]

Binary package hint: xserver-xorg-video-ati

agpFastWrite is wisely off by default (this is set while parsing xorg.conf). However, if the user specifies "on", the log will say it's on, but it's actually disabled in the code. This is because the ubuntu patch 102_radeon_fix_agp_fastwrite.diff unconditionally turns off agpFastWrite (the code comment says falsely "by default"). The second part of that patch is valid, it actually turns off the agpFastWrite flag in "mode" when it should.

[Tormod Volden (tormodvolden)]

Here is the corrected patch.

[Tormod Volden (tormodvolden)]

Here's a debdiff in case that would be convenient.

[Tormod Volden (tormodvolden)]

My above patch is not needed. I looked again at the code (src/radeon_dri.c line 742), and the mode bits are cleared to start with, including the fastwrite bit:
 mode &= ~RADEON_AGP_MODE_MASK;
RADEON_AGP_FW_MODE (0x10) is part of RADEON_AGP_MODE_MASK (0x17) and will therefore be cleared.

So bottom line, please just drop 102_radeon_fix_agp_fastwrite.diff. Both parts of the patch are not needed.

If anything should be done, it would be to write a warning if fastwrite is enabled in xorg.conf.

[Bryce Harrington (bryce)]

Thanks for the research. The next version of -ati we'll be uploading will not have this patch.

[Timo Aaltonen (tjaalton)]

I'll merge 6.6.193-1 soon and drop the patch.

[Timo Aaltonen (tjaalton)]

xserver-xorg-video-ati (1:6.6.193-1ubuntu1) gutsy; urgency=low

  * Merge from Debian experimental, remaining changes:
    - debian/control:
      + Change maintainer address.
  * New upstream release. (LP: #122979)
  * Dropped obsolete patches:
    - 100_radeon_enable_bios_hotkeys_by_default.diff
      + OPTION_BIOS_HOTKEYS dropped upstream.
    - 102_radeon_fix_agp_fastwrite.diff (LP: #115517).
  * Dropped patch 105_fdo_att7409_bug5437.diff, which is not going
    upstream, and potentially breaks other setups.
  * Dropped patches merged upstream:
    101_radeon_dac_power.diff
    103_fix_misdetection_of_some_chipsets.diff
    104_radeon_rv280_cp_twopointlines.diff
    106_radeon_predownscale_to_make_hd_video_work.diff
    107_radeon_reupload_textures_on_resume.diff

 -- Timo Aaltonen <email address hidden> Thu, 9 Aug 2007 12:43:55 +0300

[Tormod Volden (tormodvolden)]

By the way, why was 6.6.193-1 merged instead of just synced?