Warning when adding a new user or add users via CSV

[Son Nguyen]

Version: master
Platform: all
Browser: all

1. Login as site admin
2. Turn 'License metadata' setting on (in Configure site/General settings)
3. Add a new user or add users via CSV will issue warnings:

[WAR] a7 (lib/pieforms/pieform.php:1212) Invalid value for select "licensedefault"
Call stack (most recent first):
log_message("Invalid value for select "licensedefault"", 8, true, true, "/home/sonn/code/mahara/htdocs/lib/pieforms/pieform...", 1212) at /home/sonn/code/mahara/htdocs/lib/errors.php:446
error(1024, "Invalid value for select "licensedefault"", "/home/sonn/code/mahara/htdocs/lib/pieforms/pieform...", 1212, array(size 2)) at Unknown:0
trigger_error("Invalid value for select "licensedefault"", 1024) at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:1212
Pieform::info("Invalid value for select "licensedefault"") at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform/elements/select.php:100
pieform_element_select(object(Pieform), array(size 12)) at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:1378
Pieform->build_element_html(array(size 12)) at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:659
Pieform->build() at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:162
Pieform::process(array(size 7)) at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:71
pieform(array(size 7)) at /home/sonn/code/mahara/htdocs/admin/users/add.php:164

[Son Nguyen (ngson2000)]

https://reviews.mahara.org/2050

[Son Nguyen (ngson2000)]

Note for testing: you have to turn OFF the "Allow custom licenses" setting (in Configure site/General settings)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2050
Committed: http://gitorious.org/mahara/mahara/commit/0f880ea799e830197accf7398a78315b260e5436
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 0f880ea799e830197accf7398a78315b260e5436
Author: Son Nguyen <email address hidden>
Date: Fri Mar 15 10:02:45 2013 +1300

    Fix warnings when adding a new user (Bug #1154928)

    The initial value of default license is not properly set

    Change-Id: I7b3584590532bb8c4836c67a6c523355b2d15548
    Signed-off-by: Son Nguyen <email address hidden>