auth_token needs doc info and other readability improvements
Bug #1154768 reported by
Henry Nash
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| python-keystoneclient |
Fix Released
|
Low
|
Henry Nash | ||
Bug Description
A few suggestions from a recent review of auth_token didn't make it into the patch, but they still have value:
- Additional clarifications in the doc info of the module as two which variables are set with v2/v3 tokens
- Remove the duplicate specification of the above that exists in build_user_headers(
- Separate out the test for whether a token is v2 or v3 into a function
| affects: | keystone → python-keystoneclient |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to python-keystoneclient (master) | #1 |
| Changed in python-keystoneclient: | |
| status: | New → Fix Committed |
| Changed in python-keystoneclient: | |
| milestone: | none → 0.2.3 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: http://
Submitter: Jenkins
Branch: master
commit 3807a86d1f45f2b
Author: Henry Nash <email address hidden>
Date: Wed Mar 13 21:58:14 2013 +0000
Doc info and other readability improvements
A few good suggestions were made on the final round of reviews
on the previous patch to add v3 token support, but were not
implemented. This patch applies these, which should not create
any functional change.
Fixes Bug #1154768
Change-Id: Ie5408a5477d176