Engine exception handling error

Bug #1154708 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Steven Hardy

Bug Description

As pointed out by Zane, there is a problem with one of the except clauses in service.py:

 # We're expecting EC2 credentials because all in-instance credentials
        # are deployed as ec2 keypairs
        try:
            ec2_creds = json.loads(cnxt.aws_creds).get('ec2Credentials')
        except TypeError, AttributeError:
            ec2_creds = None

The TypeError, AttributeError should be inside a tuple or this won't work as required, (ref PEP3110)

Steven Hardy (shardy)
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Steven Hardy (shardy)
milestone: none → grizzly-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24347

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/24347
Committed: http://github.com/openstack/heat/commit/834b87a258a162ff8462de98b54a8036bf592d87
Submitter: Jenkins
Branch: master

commit 834b87a258a162ff8462de98b54a8036bf592d87
Author: Steven Hardy <email address hidden>
Date: Wed Mar 13 18:03:34 2013 +0000

    heat engine : fix exception syntax issue

    Fix exception clause to use a tuple or the two types of
    exception are not correctly caught.

    fixes bug 1154708

    Change-Id: Ia742c92dc189d03f8034ca864334526f1234dde3

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.