Cells traceback when deleting instance not assigned to cell

[Chris Behrens]

2013-03-12 21:09:24.317 ERROR nova.cells.messaging [req-170d033c-59bc-4428-8d22-4f8eac5e21ee 206834 4801] Error processing message locally: format requires a mapping
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging Traceback (most recent call last):
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging File "/foo/nova/lib/python2.6/site-packages/nova-2013.1.a4334.gae747d4-py2.6.egg/nova/cells/messaging.py", line 198, in _process_locally
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging resp_value = self.msg_runner._process_message_locally(self)
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging File "/foo/nova/lib/python2.6/site-packages/nova-2013.1.a4334.gae747d4-py2.6.egg/nova/cells/messaging.py", line 1038, in _process_message_locally
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging return fn(message, **message.method_kwargs)
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging File "/foo/nova/lib/python2.6/site-packages/nova-2013.1.a4334.gae747d4-py2.6.egg/nova/cells/messaging.py", line 842, in instance_delete_everywhere
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging locals(), instance=instance)
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging File "/usr/lib/python2.6/logging/__init__.py", line 1304, in debug
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging msg, kwargs = self.process(msg, kwargs)
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging File "/foo/nova/lib/python2.6/site-packages/nova-2013.1.a4334.gae747d4-py2.6.egg/nova/openstack/common/log.py", line 246, in process
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging instance_extra = CONF.instance_format % instance
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging TypeError: format requires a mapping
2013-03-12 21:09:24.317 17726 TRACE nova.cells.messaging

This is because:

nova/compute/cells_api.py: 259 self.cells_rpcapi.instance_delete_everywhere(context,
260 instance['uuid'], delete_type)

instance_delete_everywhere() accepts an instance, not an instance_uuid.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24252

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24252
Committed: http://github.com/openstack/nova/commit/e4d52f45c65704a3c153137a3d997aa3cccd8a79
Submitter: Jenkins
Branch: master

commit e4d52f45c65704a3c153137a3d997aa3cccd8a79
Author: Chris Behrens <email address hidden>
Date: Tue Mar 12 22:14:08 2013 +0000

    Fix cells instance deletion

    Instance delete and soft_delete are broken with cells when the API
    doesn't know the cell of an instance. A traceback occurs in all child
    cells. Also: soft_delete results in a 'hard' type being sent to
    child cells vs 'soft'.

    Fixes bug 1154333

    Change-Id: I13ac839fa13a66caa100a3459bcc8e1183821ff1