nova.compute.manager should list ConsoleTypeInvalid as a client exception

Bug #1154301 reported by Russell Bryant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Russell Bryant

Bug Description

get_vnc_console() and get_spice_console() in nova.compute.manager should list ConsoleTypeInvalid as a client exception for rpc. This prevents the rpc layer from logging a traceback for this exception when raised. It is an expected type of exception that the client should be left to handle how it would like.

Changed in nova:
assignee: nobody → Russell Bryant (russellb)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24248

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/24248
Committed: http://github.com/openstack/nova/commit/1df14918988ba45fc95b6925a617238af398cc50
Submitter: Jenkins
Branch: master

commit 1df14918988ba45fc95b6925a617238af398cc50
Author: Russell Bryant <email address hidden>
Date: Tue Mar 12 17:21:33 2013 -0400

    List ConsoleTypeInvalid as a client exception.

    get_vnc_console() and get_spice_console() in nova.compute.manager should
    list ConsoleTypeInvalid as a client exception for rpc. This prevents the
    rpc layer from logging a traceback for this exception when raised. It is
    an expected type of exception that the client should be left to handle
    how it would like.

    Fix bug 1154301.

    Change-Id: I3a359cbb4edbfabea1775e927b6f9947db26a284

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.