Can't delete AWS::CloudFormation::Stack resources

[Zane Bitter]

https://review.openstack.org/#/c/23635/ introduced a change to set the resource_id of a NestedStack (AWS::CloudFormation::Stack) to the ARN of the stack. However, the resource_id is part of the abstraction provided by the StackResource class, and this change overrides only part of that. Specifically, whenever the resource is retrieved from the DB, the stack object is accessed through the StackResource.nested() method, which relies on the resource_id being set to the UUID of the child stack. This means we will never be able to load the NestedStack resource from the DB after it is created.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24227

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24227
Committed: http://github.com/openstack/heat/commit/b15bd9d778772ed86d5a0d8a8be92485596127a9
Submitter: Jenkins
Branch: master

commit b15bd9d778772ed86d5a0d8a8be92485596127a9
Author: Zane Bitter <email address hidden>
Date: Tue Mar 12 19:29:38 2013 +0100

    Revert NestedStack FnGetRefId changes

    This partially reverts commit e376c83cbd57c0720336848e4b82e3b7b804a347.

    Allow StackResource to set the resource_id, since it will be the one
    retrieving the stack using it.

    Fixes bug #1154202

    Change-Id: I2140afb4e9bf89b4eb73e45f4ef5974df98e87e1