soft delete values in InstanceSystemMetadata on instance delete

[Joe Gordon]

soft delete values in InstanceSystemMetadata on instance delete.

Currently InstanceSystemMetadata is used in notify_usage_exists_deleted_instance. Non-deleted systemInstanceMetadta is currently used (with deleted instances).

https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L755

In order to fix this the read_deleted flag needs to work for joined tables.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23772
Committed: http://github.com/openstack/nova/commit/fc561270d8600ae4ce914acf90eb560601732ca8
Submitter: Jenkins
Branch: master

commit fc561270d8600ae4ce914acf90eb560601732ca8
Author: Joe Gordon <email address hidden>
Date: Thu Mar 7 00:41:48 2013 +0000

    Delete instance metadata when delete VM

    * like everything else instance metadata is just soft deleted.
    * This doesn't soft delete instance_system_metadata (bug 1153827)

    Fix bug 1092408

    Change-Id: Iebc2c7e055a110e5067829569127a272a1a92a87

[Joe Gordon (jogo)]

Originally InstanceMetadata and InstanceSystemMetadata couldn't be deleted because that data was needed to send out notifications for deleted instances (https://code.launchpad.net/bugs/1021830). But since no-db-compute a instance object is passed in pre-deletion instead (https://review.openstack.org/#/c/20354/2/nova/notifications.py). So now we can go back to deleting InstanceSystemMetadata when deleting an instance.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24387

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24387
Committed: http://github.com/openstack/nova/commit/17bca438954638d74035d560e826a26a532b3ea3
Submitter: Jenkins
Branch: master

commit 17bca438954638d74035d560e826a26a532b3ea3
Author: Joe Gordon <email address hidden>
Date: Wed Mar 13 16:58:13 2013 -0700

    Delete InstanceSystemMetadata on instance deletion

    Thanks to no-db-compute only pre-delete instance data is used in
    notifications. So now we can go back to deleting InstanceSystemMetadata
    when an instance is deleted.

    Fixes bug 1153827

    Change-Id: Ic66b998cde2a15a24f302f08c34753a8b57da73d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/28614

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/28614
Committed: http://github.com/openstack/nova/commit/a35e0f4292392cbe6a69b5155bca594a91d38316
Submitter: Jenkins
Branch: stable/grizzly

commit a35e0f4292392cbe6a69b5155bca594a91d38316
Author: Joe Gordon <email address hidden>
Date: Wed Mar 13 16:58:13 2013 -0700

    Delete InstanceSystemMetadata on instance deletion

    Thanks to no-db-compute only pre-delete instance data is used in
    notifications. So now we can go back to deleting InstanceSystemMetadata
    when an instance is deleted.

    Fixes bug 1153827

    Change-Id: Ic66b998cde2a15a24f302f08c34753a8b57da73d
    (cherry picked from commit 17bca438954638d74035d560e826a26a532b3ea3)

[Chris Behrens (cbehrens)]

Re-opening this bug as it is not actually fixed in h-1. The previous fix needed to be reverted due to bug 1185190.

[Joe Gordon (jogo)]

After skimming the nova.db.sqlalchemy.api it looks like this is still valid. This patch had to be reverted due to https://bugs.launchpad.net/nova/+bug/1185190

The impact of this bug, is a contents from InstanceSystemMetadata are never soft deleted

[Dan Smith (danms)]

Cleaning this up will be much easier in Lemming after we drop compatibility for flavor data in system_metadata. Suggest we punt until then.

[Markus Zoeller (markus_z) (mzoeller)]

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (LIBERTY, MITAKA, OCATA, NEWTON).
  Valid example: CONFIRMED FOR: LIBERTY