conductor's quota_commit and quota_rollback don't accept project_id

Bug #1153795 reported by Chris Behrens
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Dan Smith

Bug Description

QUOTAS.rollback() and QUOTAS.commit() accept a keyword arg for 'project_id'. However, the conductor API calls do not accept it.

An example workaround is here around line 2121:

https://review.openstack.org/#/c/22482/6/nova/compute/manager.py,unified

Assuming this review lands, we'll want to clean this workaround up at some point.

Chris Behrens (cbehrens)
Changed in nova:
status: New → Triaged
importance: Undecided → Medium
Dan Smith (danms)
Changed in nova:
assignee: nobody → Dan Smith (danms)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24472

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/24472
Committed: http://github.com/openstack/nova/commit/3a48c1ad3cd39283ed9e26ff0ca2b7986a2aabea
Submitter: Jenkins
Branch: master

commit 3a48c1ad3cd39283ed9e26ff0ca2b7986a2aabea
Author: Dan Smith <email address hidden>
Date: Thu Mar 14 13:34:30 2013 -0400

    Make conductor's quota methods pass project_id properly

    Commit 652a487ed9daba9ae97f7df77ae35720322d1af3 added a workaround for
    project_id on conductor's quota methods. This fully plumbs project_id
    through to the manager (and thus the quota implementation) and removes
    the tests that verify the workaround.

    Fixes bug 1153795

    Change-Id: I7cd5e3de39acfaba7831892aff6c754569c8e1bf

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.